Add site ReaperScan #1649
Open
Add site ReaperScan #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremie8 thanks for the commit can you please fix the eslint errors? what are the links you tested? |
dteviot
reviewed
Jan 26, 2025
| const unicodeDecoded = JSON.parse(`"${input}"`); | ||
| // Decode HTML entities | ||
| const textarea = document.createElement("textarea"); | ||
| textarea.innerHTML = unicodeDecoded; |
There was a problem hiding this comment.
Google and Mozilla may refuse to accept an extension that assigns text to innerHTML. You should use DOMParser's parseFromString() to convert string to HTML. https://developer.mozilla.org/en-US/docs/Web/API/DOMParser/parseFromString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #1403 and #1064, had to do a few hacks to get it working: for the list of chapters i'm getting it from api.reaperscans.com, and i get the content of each chapter in a script on the page.