-
Notifications
You must be signed in to change notification settings - Fork 171
Implementation of Non-Gaussian transition models #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Initial commit to introduce Levy (non-Gaussian) transition models
Co-authored-by: Christopher Sherman <[email protected]>
…h initialisation.
…very well in sphinx.
|
@hpritchett-dstl Additionally, I noticed that some of my formatting changes might have affected other parts of the repository that aren’t mine. I’ll need more time to undo those, but it might be helpful if we had standardized code styles throughout the repository. For example:
Lastly, it would be really helpful to have a local development setup that mirrors the CircleCI test environment. This way, I could run the tests locally and address any issues before pushing changes. A docker image would be great! |
f788491 to
19d9940
Compare
19d9940 to
f98c93b
Compare
99d144d to
9209cf0
Compare
9209cf0 to
dff4b12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some comments on the tutorial that could do with being applied throughout to make the documentation render properly.
There is some guidance here which might be useful: https://sphinx-gallery.github.io/stable/syntax.html - you can also render the docs locally by running python -m sphinx -W docs/source docs/build.
docs/tutorials/11_LevyTransitionModels_&_MarginalisedParticleFilter.py
Outdated
Show resolved
Hide resolved
docs/tutorials/11_LevyTransitionModels_&_MarginalisedParticleFilter.py
Outdated
Show resolved
Hide resolved
docs/tutorials/11_LevyTransitionModels_&_MarginalisedParticleFilter.py
Show resolved
Hide resolved
docs/tutorials/11_LevyTransitionModels_&_MarginalisedParticleFilter.py
Outdated
Show resolved
Hide resolved
docs/tutorials/11_LevyTransitionModels_&_MarginalisedParticleFilter.py
Outdated
Show resolved
Hide resolved
12968ab to
eb57eab
Compare
eb57eab to
5c77e78
Compare
@hpritchett-dstl
Features:
Refactored:
LevyLangevinmodelTodo:
Additional comments:
I believe the current design is a good compromise between speed and compatibility with the existing stone soup framework to avoid introducing any breaking changes. The newly introduced models decouple the deterministic (transition model) and non-deterministic (noise driver) components. That being said, suggestions are welcome and highly appreciated.