Feature/update array#304
Open
jscharett wants to merge 2 commits into
Open
Conversation
During the build, _.isEqual is getting replaced with isEqual from the import. This is conflicting with the local isEqual causing a circular issue.
|
@jscharett it's great, but could you help me please?
I've tried to exchange setValue to patchValue, but my nested array was removed |
Contributor
Author
|
@mcnevan Does this PR break your scenario with the nested array, or just not fix it? |
|
@jscharett oh, I think just not fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What changes does this PR include (check all that apply)?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build process changes
[ ] Documentation changes
[ ] Other... please describe:
Related issue / current behavior
Two issue here:
New behavior
enum validator conflict resolved
JsonSchemaFormService.updateArrayCheckboxList renamed to updateArray and set as protected. JsonSchemaFormService.updateValue now calls this internally for arrays.
Does this PR introduce a breaking change?
[x] Yes; JsonSchemaFormService.updateArrayCheckboxList no longer available