fix(deps): floor huggingface-hub at major-only (>=1.0.0)#60
Merged
Conversation
Renovate PR #56 merged with `huggingface-hub>=1.16.1`. Per the new lower-bounds policy (JacobPEvans-personal/.github#344), `>=` floors should express the major version only. Rewrite to `>=1.0.0`. Other security-fix floors in this file (pyarrow, pillow, orjson, idna) intentionally pin at the CVE-fix patch version per the inline comment and are left untouched.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the minimum version requirement for huggingface-hub in space/requirements.txt from 1.16.1 to 1.0.0. A review comment identifies an inconsistency between this change and the version specified in pyproject.toml, recommending an update to the latter to ensure environment parity.
…1.0.0 Addresses gemini-code-assist review on PR #60. The space/requirements.txt fix to `>=1.0.0` left pyproject.toml at `>=0.23` and the uv.lock specifier matching it, creating cross-file drift. All three now express the major-only floor consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
huggingface-hub>=1.16.1→huggingface-hub>=1.0.0inspace/requirements.txtto match the new major-only floor policy.Why
Renovate PR #56 merged with
>=1.16.1from the now-superseded behavior in PR #343. The follow-up policy in JacobPEvans-personal/.github#344 restricts>=floor bumps to majors and targets>=N.0.0form (minor/patch positions are never minimums). Bringing this file into line with the new policy.PR #57 (
google-adk>=2.0.0) already lands in major-only form — no fix needed there.The other floors in this file (
pyarrow,pillow,orjson,idna) are intentionally pinned at the CVE-fix patch version per the inline comment block. Those stay as-is.Test plan
>=1.0.0is satisfied by current 1.16.x).