Enforce code style using cpplint

.github/workflows/lgm-ci.yml

@@ -14,16 +14,24 @@ jobs:
   basic-suite:
     runs-on: ubuntu-20.04
     steps:
-    - name: Install dependencies
+    - name: Install python
+      uses: actions/setup-python@v5
+      with:
+        python-version: "3.10"
+    - name: Install dependencies for C lib
       run: |
         sudo apt-get update -qq
         sudo apt-get install -y make gcc g++ autotools-dev autoconf check
         sudo apt-get install -y libgsl-dev libgsl23 gsl-bin libgsl-dbg
         sudo apt-get install -y libhdf5-dev libperl-dev
         gcc --version
         gsl-config --version
+        python -m pip install cpplint
     - name: Checkout
       uses: actions/checkout@v2
+    - name: Code style checks
+      run: |
+        cpplint --filter=-whitespace,-readability,+build,-build/include_subdir,-build/header_guard,-build/include_what_you_use,-legal,+runtime,-runtime/int,-runtime/printf,-runtime/threadsafe_fn --linelength=120 --exclude=Examples/KdTree/magConj.c Examples/*/*.h Examples/*/*.c Tools/*.c libLanlGeoMag/Lgm_* libLanlGeoMag/Lgm/Lgm_*
     - name: compile_test
       run: |
         autoreconf -i

Examples/AE8_AP8/AE8_AP8.c

@@ -1,5 +1,5 @@
-#include <stdio.h>
 #include <math.h>
+#include <stdio.h>
 #include <Lgm_AE8_AP8.h>
 int main( ) {
 

Examples/FluxToPSD/CDFUtils.c

@@ -1,13 +1,13 @@
-#include "CDFUtils.h"
-#include <math.h>
 #include <argp.h>
 #include <cdf.h>
-#include <stdlib.h>
-#include <stdio.h>
 #include <gsl/gsl_spline.h>
-#include <Lgm/Lgm_DynamicMemory.h>
 #include <Lgm/Lgm_CTrans.h>
+#include <Lgm/Lgm_DynamicMemory.h>
 #include <Lgm/Lgm_Quat.h>
+#include <math.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include "CDFUtils.h"
 
 
 /*

Examples/FluxToPSD/CDFUtils.h

@@ -2,8 +2,8 @@
 #define CDF_UTILS_H
 
 #include <cdf.h>
-#include <stdlib.h>
 #include <stdio.h>
+#include <stdlib.h>
 
 
 /*

Examples/FluxToPSD/DumpSvg.c

@@ -1,7 +1,7 @@
+#include <math.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <math.h>
 
 typedef struct CoordInfo {
 

Examples/FluxToPSD/FluxToPSD.c

@@ -3,26 +3,26 @@ CHECK ME FOR MEMORY LEAKS.....
 THIS ALSO eeds some argument changes...
 e.g. The Mu's K's instead of pitch angles...
 */
-#include "CDFUtils.h"
-#include <stdlib.h>
+#include <argp.h>
+#include <ctype.h>
+#include <fcntl.h>
+#include <libgen.h>
 #include <stdio.h>
-#include <unistd.h>
-#include <sys/types.h>
+#include <stdlib.h>
 #include <sys/stat.h>
-#include <fcntl.h>
-#include <ctype.h>
-#include <argp.h>
+#include <sys/types.h>
 #include <time.h>
-#include <libgen.h>
-#include <Lgm/Lgm_CTrans.h>
-#include <Lgm/Lgm_Sgp.h>
-#include <Lgm/Lgm_DynamicMemory.h>
-#include <Lgm/Lgm_MagModelInfo.h>
-#include <Lgm/Lgm_FluxToPsd.h>
-#include <Lgm/Lgm_Eop.h>
-#include <Lgm/Lgm_QinDenton.h>
-#include <Lgm/Lgm_Misc.h>
-#include <Lgm/Lgm_HDF5.h>
+#include <unistd.h>
+#include <Lgm_CTrans.h>
+#include <Lgm_DynamicMemory.h>
+#include <Lgm_Eop.h>
+#include <Lgm_FluxToPsd.h>
+#include <Lgm_HDF5.h>
+#include <Lgm_MagModelInfo.h>
+#include <Lgm_Misc.h>
+#include <Lgm_QinDenton.h>
+#include <Lgm_Sgp.h>
+#include "CDFUtils.h"
 
 
 

Examples/FluxToPSD/MuTest.c

@@ -1,5 +1,5 @@
-#include <stdio.h>
 #include <math.h>
+#include <stdio.h>
 #include <Lgm_MagModelInfo.h>
 #include <Lgm_FluxToPsd.h>
 int main( ) {

Examples/FluxToPSD/f2p.c

@@ -1,5 +1,5 @@
-#include <stdio.h>
 #include <math.h>
+#include <stdio.h>
 #include <Lgm_MagModelInfo.h>
 #include <Lgm_FluxToPsd.h>
 int main( ) {

Examples/FluxToPSD/f2p_v2.c

@@ -1,5 +1,5 @@
-#include <stdio.h>
 #include <math.h>
+#include <stdio.h>
 #include <Lgm_MagModelInfo.h>
 #include <Lgm_FluxToPsd.h>
 void DumpSvg( int,  char * );

Examples/KdTree/DstNNs.c

@@ -1,11 +1,11 @@
-#include <stdlib.h>
 #include <math.h>
+#include <quicksort.h>
+#include <stdio.h>
+#include <stdlib.h>
 #include <Lgm_DynamicMemory.h>
-#include <Lgm_ElapsedTime.h>
 #include <Lgm_CTrans.h>
+#include <Lgm_ElapsedTime.h>
 #include <Lgm_KdTree.h>
-#include <quicksort.h>
-#include <stdio.h>
 int main( ) {
     Lgm_ElapsedTimeInfo t;
     double              *q, **u, **B, *Dst, DstIndex, dum1, dum2, dum3;

Examples/KdTree/TLE_NNs.c

@@ -1,12 +1,12 @@
-#include <stdlib.h>
 #include <math.h>
+#include <quicksort.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <Lgm_CTrans.h>
 #include <Lgm_DynamicMemory.h>
 #include <Lgm_ElapsedTime.h>
-#include <Lgm_CTrans.h>
 #include <Lgm_KdTree.h>
 #include <Lgm_Sgp.h>
-#include <quicksort.h>
-#include <stdio.h>
 int main( ) {
     Lgm_ElapsedTimeInfo t;
     double              *q, **u, **B, DstIndex, dum1, dum2, dum3;

Examples/KdTree/magConj.c

@@ -1,15 +1,15 @@
-#include <stdlib.h>
-#include <stdio.h>
-#include <math.h>
-#include <libgen.h>
-#include <glob.h>
 #include <argp.h>
+#include <glob.h>
+#include <libgen.h>
+#include <math.h>
 #include <regex.h>
-#include <Lgm_DynamicMemory.h>
+#include <stdio.h>
+#include <stdlib.h>
 #include <Lgm_CTrans.h>
+#include <Lgm_DynamicMemory.h>
+#include <Lgm_HDF5.h>
 #include <Lgm_KdTree.h>
 #include <Lgm_Misc.h>
-#include <Lgm_HDF5.h>
 
 void StringSplit( char *Str, char *StrArray[], int len, int *n );
 

Examples/KdTree/test.c

@@ -1,9 +1,9 @@
-#include <stdlib.h>
 #include <math.h>
+#include <quicksort.h>
+#include <stdlib.h>
 #include <Lgm_DynamicMemory.h>
 #include <Lgm_ElapsedTime.h>
 #include <Lgm_KdTree.h>
-#include <quicksort.h>
 int main( ) {
     Lgm_ElapsedTimeInfo t;
     double              **q, **u, **B;

Examples/LCDS/LCDS.c

@@ -1,15 +1,15 @@
+#include <fcntl.h>
 #include <omp.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <unistd.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <fcntl.h>
-#include <Lgm_MagModelInfo.h>
+#include <sys/types.h>
+#include <unistd.h>
 #include <Lgm_LstarInfo.h>
 #include <Lgm_MagEphemInfo.h>
-#include <Lgm_QinDenton.h>
+#include <Lgm_MagModelInfo.h>
 #include <Lgm_Misc.h>
+#include <Lgm_QinDenton.h>
 
 #define MAIN
 #define TRACE_TOL   1e-7

Examples/Lstar/Lstar.c

@@ -1,7 +1,7 @@
-#include <unistd.h>
-#include <sys/types.h>
-#include <sys/stat.h>
 #include <fcntl.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+#include <unistd.h>
 #include <Lgm_CTrans.h>
 #include <Lgm_LstarInfo.h>
 

Examples/LstarDipoleTest/ComputeLstarVersusPA.c

@@ -1,13 +1,13 @@
-#include <Lgm_MagModelInfo.h>
-#include <Lgm_LstarInfo.h>
-#include <Lgm_MagEphemInfo.h>
+#include <fcntl.h>
 #include <omp.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <unistd.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <fcntl.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <Lgm_LstarInfo.h>
+#include <Lgm_MagEphemInfo.h>
+#include <Lgm_MagModelInfo.h>
 
 #define TRACE_TOL   1e-7
 #define KP_DEFAULT  1

Examples/LstarDipoleTest/DynamicMemory.h

@@ -1,6 +1,6 @@
-#include <stdlib.h>
-#include <stdio.h>
 #include <malloc.h>
+#include <stdio.h>
+#include <stdlib.h>
 
 /*
  * Macros for dynamically allocating/freeing 1D arrays of any type

Examples/LstarDipoleTest/LstarVersusPA.c

@@ -1,8 +1,8 @@
 #define MAIN
-#include <unistd.h>
-#include <sys/types.h>
-#include <sys/stat.h>
 #include <fcntl.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+#include <unistd.h>
 #include <Lgm_CTrans.h>
 #include <Lgm_MagEphemInfo.h>
 

Examples/LstarDipoleTest/MagEphemInfo.h

@@ -1,8 +1,8 @@
 #ifndef MAGEPHEMINFO_H
 #define MAGEPHEMINFO_H
 
-#include <Lgm/Lgm_MagModelInfo.h>
 #include <Lgm/Lgm_LstarInfo.h>
+#include <Lgm/Lgm_MagModelInfo.h>
 
 #define MAX_PITCH_ANGLES 900
 

Examples/LstarDipoleTest_omp/ComputeLstarVersusPA.c

@@ -1,13 +1,13 @@
-#include <Lgm_MagModelInfo.h>
-#include <Lgm_LstarInfo.h>
-#include <Lgm_MagEphemInfo.h>
+#include <fcntl.h>
 #include <omp.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <unistd.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <fcntl.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <Lgm_LstarInfo.h>
+#include <Lgm_MagEphemInfo.h>
+#include <Lgm_MagModelInfo.h>
 
 #define TRACE_TOL   1e-7
 #define KP_DEFAULT  1

Examples/LstarDipoleTest_omp/DynamicMemory.h

@@ -1,6 +1,6 @@
-#include <stdlib.h>
-#include <stdio.h>
 #include <malloc.h>
+#include <stdio.h>
+#include <stdlib.h>
 
 /*
  * Macros for dynamically allocating/freeing 1D arrays of any type

Examples/LstarDipoleTest_omp/LstarVersusPA.c

@@ -1,8 +1,8 @@
 #define MAIN
-#include <unistd.h>
-#include <sys/types.h>
-#include <sys/stat.h>
 #include <fcntl.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+#include <unistd.h>
 #include <Lgm_CTrans.h>
 #include <Lgm_MagEphemInfo.h>
 

Examples/LstarDipoleTest_omp/MagEphemInfo.h

@@ -1,8 +1,8 @@
 #ifndef MAGEPHEMINFO_H
 #define MAGEPHEMINFO_H
 
-#include <Lgm/Lgm_MagModelInfo.h>
-#include <Lgm/Lgm_LstarInfo.h>
+#include <Lgm_LstarInfo.h>
+#include <Lgm_MagModelInfo.h>
 
 #define MAX_PITCH_ANGLES 900
 

Examples/LstarVersusPA_omp/ComputeLstarVersusPA.c

@@ -1,13 +1,13 @@
-#include <Lgm_MagModelInfo.h>
-#include <Lgm_LstarInfo.h>
-#include <Lgm_MagEphemInfo.h>
+#include <fcntl.h>
 #include <omp.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <unistd.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <fcntl.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <Lgm_LstarInfo.h>
+#include <Lgm_MagEphemInfo.h>
+#include <Lgm_MagModelInfo.h>
 
 #define TRACE_TOL   1e-7
 #define KP_DEFAULT  1

Examples/LstarVersusPA_omp/LstarVersusPA.c

@@ -1,8 +1,8 @@
 #define MAIN
-#include <unistd.h>
-#include <sys/types.h>
-#include <sys/stat.h>
 #include <fcntl.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+#include <unistd.h>
 #include <Lgm_CTrans.h>
 #include <Lgm_MagEphemInfo.h>