LANLGeoMag version 2.0.0-alpha#40
Merged
Merged
Conversation
…ius of r=1.0. Modified to use Lgm_LossConeHeight distance above 1.0 instead.
These updates were part of a housekeeping update for better handling of multiple minima when tracing drift shells
Previous version used legacy [1min, 1hr] naming and would report multiple failures to find a valid input file. This enforces the checks or output and updates the file resolution checks
Owner
Author
|
There are still a handful of changes from #39 that aren't reflected here. These fall into a few key categories:
I'm taking this out of draft status as a sign of near-completion. Remaining updates will be triaged and either moved to a separated effort to incorporate or included here prior to merge. This branch is just about ready for testing with any downstream applications. |
update CI to reflect configure flag change
Cherry-picked from pr39 and modified to remove extraneous debug printing
Owner
Author
|
To be done post merge:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch for finalizing LGM v2. The sets of changes currently across other branches or PRs/draft PRs will be slowly migrated to this branch, with any updates or cleanup required along the way.
Once complete and tested, this branch will be merged into master and tagged as version 2.0.0-alpha.
Changes:
RelaxToleranceargument toFindShellLineErrorStatusto all function variants ofComputeI_FromMltMlatFluxTubeVolumeandLgm_ReplaceSubString2Geodetic2)Lgm_B_FromScatteredData6