use copy_within
instead of manual logic
#38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small readability win.
https://godbolt.org/z/9s3zMebrE
memmove16
, the assembly is basically equivalent for the happy pathmemcpy_within_slice
the standard path that callsmemmove
has fewer instructionsIn practice this logic is apparently not exercised enough to show any measurable effect
Btw I'm looking through your code base as a part of this rust project goal rust-lang/rust-project-goals#258. We've learned some things in
zlib-rs
that might be useful here too.