Fixed permission names and made interface more user friendly #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pawel-IT
commented
Dec 15, 2024
Pawel-IT
commented
- The permissions in PostPolicy did not match the name of permissions created by seeder so none of the policy checks ever worked causing confusion for users trying to learn how this package works. Fixed that in the edit case, also left a wrong case with comments explaining the issue and how the permission names must match what you have in your database for those that might be using the default Policy creator from Laravel. Removed some of the policies that were not needed
- Improved the interface to give you login info on the welcome page and link to demo dashboard
- Added all the routes to demo dashboard as links
- Added posts to the DB seeder so could test permissions on the posts page.
- Documented the permissions you do have and don't have on the blade views to make things easier to understand for new users to the spatie-permissions package.
Middlewares needs to be changed to Middleware
- Fixed issue with dark mode on welcome view - Added login info to main welcome view - Added link to demo page on welcome view - Added various demo links to demo home page view
This caused confusion if you're not user ID one
and navigate
and assigned it to admin role
and added comments to code to example what is going on and make it clear when somethign will and won't work. Before this update none of these permissions did anything as they didn't match our permissions in DB.
and add nav links
|
I just realized the tests are the true demo in this package. Sorry. Will create another pull request later to match the interface to the tests as this is really confusing to new users I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.