scripts: recreate missing guildstone and fix rename bug#4
Open
pixibits wants to merge 4 commits into
Open
Conversation
pixibits
force-pushed
the
scripts-guildstone
branch
from
c18df1f to
e1d596a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores most guildstone functionality, but does not include virtue guilds or guild warfare. This can be a base for adding those features if wanted.
Requires an object to exist at 0, 0, -80 with masterguildstone attached
Guild types are not fully supported in masterguildstone - for example changing the abbreviation always sets the type to 0x00, and renaming a guild dropped the guild type altogether which would then delete the guild on next reload. Fixed by always setting the type to 0x00 on rename.
guildstone.m is entirely missing from the demo, this is rewritten using evidence from related scripts, patch notes, and the stratics guildstone page (https://web.archive.org/web/19991116040056fw_/http://uo.stratics.com/guilds.htm)
Guildstone teleporting is not implemented
Guild warfare is not implemented, but has placeholder menus as described in the April 13 patch notes (https://uo.com/wiki/ultima-online-wiki/technical/previous-publishes/1998-2/1998-8-13th-april/).