feat: add UNSIGNED support for DECIMAL/NUMERIC/FLOAT/DOUBLE and GEOGR…#945
Open
VeerShah41 wants to merge 2 commits intodrawdb-io:mainfrom
Open
feat: add UNSIGNED support for DECIMAL/NUMERIC/FLOAT/DOUBLE and GEOGR…#945VeerShah41 wants to merge 2 commits intodrawdb-io:mainfrom
VeerShah41 wants to merge 2 commits intodrawdb-io:mainfrom
Conversation
…APHY type Closes drawdb-io#880 Closes drawdb-io#878 - Add `signed: true` to DECIMAL, NUMERIC, FLOAT, and DOUBLE in mysqlTypesBase so the UNSIGNED checkbox appears in the UI for MySQL and MariaDB (which inherits from MySQL types). MySQL/MariaDB both support UNSIGNED for these numeric types. - Add GEOGRAPHY to postgresTypesBase following the same pattern as other PostGIS/geometric types (POINT, LINE, POLYGON, etc.), using geometricColor and noDefault: true. GEOGRAPHY is a core type for the widely-used PostGIS extension.
|
@VeerShah41 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Hi @1ilit, I’ve opened this PR addressing issues #880 and #878. Changes included:
Could you please take a look and let me know if any changes are needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…APHY type
Closes #880
Closes #878
Add
signed: trueto DECIMAL, NUMERIC, FLOAT, and DOUBLE in mysqlTypesBase so the UNSIGNED checkbox appears in the UI for MySQL and MariaDB (which inherits from MySQL types). MySQL/MariaDB both support UNSIGNED for these numeric types.Add GEOGRAPHY to postgresTypesBase following the same pattern as other PostGIS/geometric types (POINT, LINE, POLYGON, etc.), using geometricColor and noDefault: true. GEOGRAPHY is a core type for the widely-used PostGIS extension.