Fix SVG export to use selectable text elements instead of rasterized images#871
Open
SKaranjaN wants to merge 1 commit intodrawdb-io:mainfrom
Open
Fix SVG export to use selectable text elements instead of rasterized images#871SKaranjaN wants to merge 1 commit intodrawdb-io:mainfrom
SKaranjaN wants to merge 1 commit intodrawdb-io:mainfrom
Conversation
…images Replaced html-to-image's toSvg function with a custom implementation that converts foreignObject elements to native SVG text elements. This makes all text in exported SVG files selectable and copyable in browsers. Fixes drawdb-io#839
|
@SKaranjaN is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #839
The current SVG export uses html-to-image's oSvg function which rasterizes text content inside oreignObject elements, making it unselectable in browsers.
This PR replaces the export implementation with a custom solution that:
The exported SVG files now contain true SVG text elements that can be selected in any browser.