fix(import): improve SQL parsing compatibility by sanitizing input#853
Open
Gautam-Bharadwaj wants to merge 3 commits intodrawdb-io:mainfrom
Open
fix(import): improve SQL parsing compatibility by sanitizing input#853Gautam-Bharadwaj wants to merge 3 commits intodrawdb-io:mainfrom
Gautam-Bharadwaj wants to merge 3 commits intodrawdb-io:mainfrom
Conversation
- Added sanitizeSQL utility to strip comments and unsupported meta-commands (SET, SELECT, CREATE EXTENSION) - Integrated sanitization in Import Modal to fix crashes with pg_dump files - Preserved strings containing comment-like characters
|
@Gautam-Bharadwaj is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#PR- #852
Description
This PR addresses the issue where importing SQL files (mainly PostgreSQL dumps generated by pg_dump) fails with syntax errors. The root cause is the strictness of the node-sql-parser library, which crashes when encountering valid dump artefacts like meta-commands (SET statement_timeout...) or complex comments.
We have introduced a Sanitisation Layer to strip these non-structural elements before parsing.
Before vs After
Before
The raw SQL string from the import modal was passed directly to the parser.
Result: Syntax Error (Parser chokes on SET and sometimes --).
After
The SQL string is processed by sanitizeSQL before parsing.
After Sanitization (Internal):
Result: Success (Parser sees specialized DDL only).
Verification
Verified that strings containing comment markers (e.g. '-- data') are preserved correctly.
Verified that SET commands at the top of files are removed.
Verified that block comments /* ... */ are removed.