Skip to content

Commit

Permalink
Stream domains from txt instead of loading whole json file
Browse files Browse the repository at this point in the history
Adding more domains is more convenient because the git diff is prettier
and you don't need quotes and commas.

Also, it's more memory-efficient to read the file line by line instead
of loading the whole file into memory, although it's negligible with
such a small file.
  • Loading branch information
draperunner committed Aug 25, 2023
1 parent c1894e2 commit dab7f35
Show file tree
Hide file tree
Showing 3 changed files with 120 additions and 121 deletions.
118 changes: 0 additions & 118 deletions domains.json

This file was deleted.

116 changes: 116 additions & 0 deletions domains.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
stortinget.no
regjeringen.no
domstol.no
lovdata.no
politiet.no
forsvaret.no
nav.no
komplett.no
elkjop.no
trumf.no
coop.no
obs.no
jernia.no
multicom.no
megaflis.no
power.no
proshop.no
staypro.no
jula.no
nordicdream.no
whiteaway.no
skousen.no
xxl.no
netonnet.no
soundgarden.no
cdon.no
hifiklubben.no
ark.no
dustinhome.no
fjellsport.no
milrab.no
outnorth.no
kitchn.no
tilbords.no
norli.no
kjell.com
sportsnett.no
ellos.no
nelly.com
miinto.no
entur.no
entur.org
vy.no
posten.no
postnord.no
digipost.no
1881.no
danskebank.no
spv.no
dnb.no
sparebank1.no
banknorwegian.no
eika.no
gjensidige.no
klp.no
sbanken.no
santander.no
if.no
obos.no
storebrand.no
dep.no
landkreditt.no
landkredittbank.no
komplettbank.no
pst.no
nsm.no
skatteetaten.no
uio.no
ntnu.no
digdir.no
ks.no
altinn.no
ruter.no
nrk.no
aftenposten.no
dagbladet.no
tv2.no
e24.no
finn.no
nettavisen.no
dn.no
bt.no
adressa.no
finansavisen.no
aftenbladet.no
oslohavn.no
oda.com
uit.no
uis.no
uib.no
uia.no
nmbu.no
oslomet.no
norge.no
spar.no
kiwi.no
rema.no
meny.no
vipps.no
kode24.no
norid.no
atea.no
altibox.no
visma.no
toogoodtogo.no
kk.no
bohus.no
zalando.no
sportmann.no
usbl.no
dyreparken.no
ntb.no
nettbil.no
kartverket.no
norgeskart.no
morrowbank.no
7 changes: 4 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { resolveTxt } from "dns";
import { readFileSync, writeFileSync, mkdirSync } from "fs";

import DOMAINS from "./domains.json" assert { type: "json" };
import { open } from "fs/promises";

function getTxtRecords(hostname) {
return new Promise((resolve, reject) =>
Expand Down Expand Up @@ -53,7 +52,9 @@ function getTimeElement() {
async function main() {
const dmarcs = [];

for (const domain of DOMAINS) {
const domainsFile = await open("./domains.txt");

for await (const domain of domainsFile.readLines()) {
const dmarc = await getDmarcRecord(domain);

dmarcs.push({
Expand Down

0 comments on commit dab7f35

Please sign in to comment.