fix: #41 Fixed the bug that the beforeunload event was triggered incorrectly - #64
Open
jooooock wants to merge 1 commit into
Open
fix: #41 Fixed the bug that the beforeunload event was triggered incorrectly#64jooooock wants to merge 1 commit into
jooooock wants to merge 1 commit into
Conversation
…ggered incorrectly
yurifrl
added a commit
to yurifrl/obsidian-tray
that referenced
this pull request
Jul 11, 2026
- dragonwocky#58: second-instance handler reveals hidden window instead of opening vault picker (fixes can't-reopen-after-close) - dragonwocky#35: stash native Tray on globalThis so plugin reload destroys the orphaned icon instead of duplicating it - dragonwocky#64: skip beforeunload hide for in-app link navigation - dragonwocky#68: isQuitting flag lets windows close during macOS shutdown - dragonwocky#76: dock transition queue + new "Auto hide taskbar icon" option plus 2s reconciliation interval (fixes dock icon stuck on rapid toggle) - dragonwocky#61: obsidian://tray/toggleWindows URI handler for Linux/Wayland
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an
aelement does not have thetarget=_blankattribute set, then clicking the link will open the current page, causing the page to refresh, triggering thebeforeunloadevent, and then causing the erroneous triggering of theonWindowUnloadfunction to be executed.This modification uses a global variable
isLinkNavigationto distinguish whether thebeforeunloadevent is caused by clicking on theaelement or by closing the window.