Clicking on links, minimises Obsidian into tray

[AhmadFCheema]

Bug

Windows 11
Obsidian v1.4.13 / v1.5.3 / v1.5.8
Tray plugin v0.3.5

When Run in background option is enabled, clicking on links (link.href, a href) inside the settings of some Community plugins causes Obsidian to minimise intotray instead of opening the link.

Links which minimise Obsidian into tray:

• Banners.
• Editing Toolbar (1, 2).
• Minimal Theme Settings (1, 2, 3, 4).
• Recent files.

Links inside the settings of Core plugins and this Tray plugin work fine.

[robross0606]

Experiencing same problem. Had to disable this extension because it breaks all link functionality in notes.

[Moyf]

Same here..

[Fred-Vatin]

Obsidian	OS	Tray
1.5.12	Win 10 x64 pro (french) 22H2	0.3.5

I made a bug report to another plugin because I thought (wrongly ?) it could be the culprit.
Meikul/obsidian-thumbnails#14

When tray is installed with the option Run in background enabled, when clicking a youtube thumbnail (reading mode):

• Obsidian close to tray (it doesn’t when clicking other external link)
• Firefox gets the focus but new tab is not created to open the url.

Then I installed tadashi-aikawa/obsidian-another-quick-switcher and got the same issue when clicking on link inside their settings.

I tried with Firefox and Edge when set as default browser.

Here is another related issue: #26

[Minoo7]

Any update on this?

[rose-munaretto]

Based on my quick research digging in the code and watching logs, the issue might be caused by the onWindowUnload() function, more especially L.104

const onWindowUnload = (event) => {
    log(LOG_WINDOW_CLOSE);
    getCurrentWindow().hide();
    event.stopImmediatePropagation(); // <-- ❌ this line
    // setting return value manually is more reliable than
    // via `return false` according to electron
    event.returnValue = false;
};

---

Stack trace

1. when settings.runInBackground is true (L.279 and L.458)
2. interceptWindowClose() function is called (L.109-116)
3. onWindowUnload() event listener function is added to beforeunload event L.111
4. according to MDN, "the main use case for this event is to trigger a browser-generated confirmation dialog that asks users to confirm if they really want to leave the page when they try to [...] navigate somewhere else."
5. on link click, beforeunload event is triggered and the propagation of the event is stopped, preventing link to open

---

I'm not exactly sure why stopping the propagation prevents links to open but onWindowUnload() being called when link is clicked isn't an intended behavior.

@dragonwocky @Zarpyk @hedonihilist this project seems a bit dead (no commit since 1.5 year). If I dig more in the issue and submit a PR, could it be accepted?

[Moyf]

Based on my quick research digging in the code and watching logs, the issue might be caused by the onWindowUnload() function, more especially L.104

const onWindowUnload = (event) => {
log(LOG_WINDOW_CLOSE);
getCurrentWindow().hide();
event.stopImmediatePropagation(); // <-- ❌ this line
// setting return value manually is more reliable than
// via return false according to electron
event.returnValue = false;
};
Stack trace

1. when settings.runInBackground is true (L.279 and L.458)
2. interceptWindowClose() function is called (L.109-116)
3. onWindowUnload() event listener function is added to beforeunload event L.111
4. according to MDN, "the main use case for this event is to trigger a browser-generated confirmation dialog that asks users to confirm if they really want to leave the page when they try to [...] navigate somewhere else."
5. on link click, beforeunload event is triggered and the propagation of the event is stopped, preventing link to open

I'm not exactly sure why stopping the propagation prevents links to open but onWindowUnload() being called when link is clicked isn't an intended behavior.

@dragonwocky @Zarpyk @hedonihilist this project seems a bit dead (no commit since 1.5 year). If I dig more in the issue and submit a PR, could it be accepted?

I totally support you submitting a PR so that (at least) other users can merge it locally and address this long-standing issue 🥺

[redleafnew]

Based on my quick research digging in the code and watching logs, the issue might be caused by the onWindowUnload() function, more especially L.104
const onWindowUnload = (event) => {
log(LOG_WINDOW_CLOSE);
getCurrentWindow().hide();
event.stopImmediatePropagation(); // <-- ❌ this line
// setting return value manually is more reliable than
// via return false according to electron
event.returnValue = false;
};
Stack trace

1. when settings.runInBackground is true (L.279 and L.458)
2. interceptWindowClose() function is called (L.109-116)
3. onWindowUnload() event listener function is added to beforeunload event L.111
4. according to MDN, "the main use case for this event is to trigger a browser-generated confirmation dialog that asks users to confirm if they really want to leave the page when they try to [...] navigate somewhere else."
5. on link click, beforeunload event is triggered and the propagation of the event is stopped, preventing link to open

I'm not exactly sure why stopping the propagation prevents links to open but onWindowUnload() being called when link is clicked isn't an intended behavior.
@dragonwocky @Zarpyk @hedonihilist this project seems a bit dead (no commit since 1.5 year). If I dig more in the issue and submit a PR, could it be accepted?

I totally support you submitting a PR so that (at least) other users can merge it locally and address this long-standing issue 🥺

Does it work now?

After this event.stopImmediatePropagation(); was deleted, the link in templater can not be opened.

[redleafnew]

[Fred-Vatin]

Can not #64 be merged and a new version released ?

[dragonwocky]

Hi @Fred-Vatin and anyone else checking in on this repo - I'll have a look after exams. You're welcome to download, patch and use any of the forks yourself (the joy of open source!) or you can wait until I've got time to test the PRs and work through the list of issues properly for the next release :)

Sorry for the delay, it's been a busy time and I don't currently use Obsidian. I haven't forgotten about this though!

[Moyf]

Hi @Fred-Vatin and anyone else checking in on this repo - I'll have a look after exams. You're welcome to download, patch and use any of the forks yourself (the joy of open source!) or you can wait until I've got time to test the PRs and work through the list of issues properly for the next release :)

Sorry for the delay, it's been a busy time and I don't currently use Obsidian. I haven't forgotten about this though!

Hey dragonwocky, a bit off-topic, but I want to tell you—when I use Notion, I use Notion Enhancer (super useful!), and when I switched to Obsidian, I was surprised and delighted to find that I saw a familiar ID again—
The extensions you've developed have greatly improved the user experience of the corresponding software. Wherever you go, you bring benefits—it's truly meaningful. I salute you! Thank you!