chore(json_family): Clean up the memory tracking code for JSON mutate operations. FOURTH PR #5070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BagritsevichStepan
force-pushed
the
memory/fix-memory-tracking-for-mutate-json-operations
branch
from
91ef2af to
9e81535
Compare
|
I do not see any test changes in this PR. Does this PR removes completely JsonMemTracker? |
|
I can try to reproduce the bug in the tests |
BagritsevichStepan
changed the title
|
@romange I updated the description of the PR, there is no need in test here |
Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
memory/fix-memory-tracking-for-mutate-json-operations
branch
from
9e81535 to
6453149
Compare
romange
approved these changes
May 27, 2025
BagritsevichStepan
deleted the
memory/fix-memory-tracking-for-mutate-json-operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fourth PR that fixes memory tracking issues in JSON.
This PR cleans up the code, removes
MutateOperationOptionsas it is no longer needed, and replacesJsonMemTrackerwithJsonAutoUpdater. Although there is currently no bug withop_args.shard->search_indices()->RemoveDocafter initializingJsonMemTracker— since the current JSON API does not allow this issue to be reproduced — it is still considered bad practice. To prevent potential future bugs,JsonAutoUpdateris used instead.Bugs that were found and fixed:Bug in JsonMutateOperation, where we calledop_args.shard->search_indices()->RemoveDocafter starting the memory tracking.RemoveDochas a static cache that may allocate some memory, but this memory does not belong to the JSON object itself. As a result, memory usage will be overestimated in this case.