Skip to content

Conversation

@jdrouet
Copy link

@jdrouet jdrouet commented Feb 27, 2025

This should fix #1206

I don't know what is the way to detect if the snippets directory should be included so, by default, I include it considering it's already in the sideEffect section.
Another possibility would be to add to the Cargo.toml metadata a package-json section that allows to add some files and enforce it there.

Tell me if it's ok with you or if you need some updates 😉

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@LuisOsta
Copy link

@jdrouet When do you think this PR would be merged? Do you have any idea of who we should reach out to about this?

@LuisOsta
Copy link

LuisOsta commented Jul 21, 2025

@drager @ashleygwilliams Is there something this PR needs before its ready to merge?

@jdrouet
Copy link
Author

jdrouet commented Jul 22, 2025

Honestly, an approval from the maintainer 😁

@LuisOsta
Copy link

I tested this on my repo and verified that it worked for us FWIW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snippets directory is not included in files of package.json

2 participants