fix: add the snippets directory by default#1479
Open
jdrouet wants to merge 1 commit intodrager:masterfrom
Open
fix: add the snippets directory by default#1479jdrouet wants to merge 1 commit intodrager:masterfrom
jdrouet wants to merge 1 commit intodrager:masterfrom
Conversation
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
|
@jdrouet When do you think this PR would be merged? Do you have any idea of who we should reach out to about this? |
|
@drager @ashleygwilliams Is there something this PR needs before its ready to merge? |
Author
|
Honestly, an approval from the maintainer 😁 |
|
I tested this on my repo and verified that it worked for us FWIW |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #1206
I don't know what is the way to detect if the
snippetsdirectory should be included so, by default, I include it considering it's already in thesideEffectsection.Another possibility would be to add to the
Cargo.tomlmetadata apackage-jsonsection that allows to add some files and enforce it there.Tell me if it's ok with you or if you need some updates 😉
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨