Don't create .gitignore in pkg directory#1408
Open
mrothNET wants to merge 1 commit intodrager:masterfrom
Open
Conversation
rimutaka
approved these changes
Jan 10, 2025
rimutaka
left a comment
There was a problem hiding this comment.
LGTM. I wonder why it hasn't been merged.
|
was looking for this, hope it gets merged soon |
|
any progress? |
|
bumping! it seems very strange that this is on by default as it's very easy for a dev to add it themselves and causes issues when we want to version control the autogenerated type files |
|
Would be really nice to see get added, with |
0dpe
added a commit
to 0dpe/path_tracer
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #728
Closes #984,
Closes #909
Closes #999.
Supersedes #1131, #985
Problematic Behaviour
Currently,
wasm-packgenerates a.gitignorefile in thepkgdirectory during each build.Suggested Solution
This PR proposes removing the automatic creation of the
.gitignorefile without introducing a replacement.Justification
While many tools generate an appropriate
.gitignoreduring project initialization, it’s relatively uncommon (in my experience) for build tools, like compilers, to create.gitignorefiles during a build.Moreover, this behavior has led to several issues, as outlined in the following requests:
.gitignoregeneration #728build --target web: have an option not to add .gitignore to pkg output folder #999This PR aims to remove the generation of the problematic
.gitignorefile, addressing and potentially superseding these other PRs:Changes made