Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Commit

Permalink
Disable --limit-to-items-without-p921 for now
Browse files Browse the repository at this point in the history
Update README.md
  • Loading branch information
dpriskorn committed Oct 6, 2022
1 parent 4f38971 commit a97f3ea
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,10 @@ Usage example:
`poetry run python itemsubjector.py -a Q34 --show-item-urls`
(the shorthand `-iu` also works)

### Limit to scholarly articles without main subject
Usage example:
`poetry run python itemsubjector.py -a Q34 --limit-to-items-without-p921`
(the shorthand `-w` also works)
[//]: # (### Limit to scholarly articles without main subject)
[//]: # (Usage example:)
[//]: # (`poetry run python itemsubjector.py -a Q34 --limit-to-items-without-p921` )
[//]: # ((the shorthand `-w` also works))

## Matching main subjects based on a SPARQL query.
The tool can create a list of jobs by picking random subjects from a
Expand Down Expand Up @@ -225,8 +225,6 @@ optional arguments:
Remove prepared jobs
-m, --match-existing-main-subjects
Match from list of 136.000 already used main subjects on other scientific articles
-w, --limit-to-items-without-p921
Limit matching to scientific articles without P921 main subject
-su, --show-search-urls
Show an extra column in the table of search strings with links
-iu, --show-item-urls
Expand Down Expand Up @@ -258,6 +256,8 @@ removed the QuickStatements export to simplify the program.
* Simplify as much as possible to keep the whole thing lean and avoid scope creep. -> helps reuse in other projects. (KISS-principle)
* Difficult to judge which features are used and which are not. User testing would be nice.
* UML diagrams are nice. They give a good quick overview.
* Removing options that no-one seems to use helps keeping it simple. It would be valuable to get better insight of how the
program is used by the users. A discussion in github might help in this.

# Thanks
During the development of this tool the author got a
Expand Down
12 changes: 6 additions & 6 deletions src/helpers/argparse_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ def setup_argparse_and_return_args():
action="store_true",
help="Remove prepared jobs",
)
parser.add_argument(
"-w",
"--limit-to-items-without-p921",
action="store_true",
help="Limit matching to scientific articles without P921 main subject",
)
# parser.add_argument(
# "-w",
# "--limit-to-items-without-p921",
# action="store_true",
# help="Limit matching to scientific articles without P921 main subject",
# )
parser.add_argument(
"-su",
"--show-search-urls",
Expand Down

0 comments on commit a97f3ea

Please sign in to comment.