Repository navigation
edit: add --field to edit a single field - #367
Open
NanShanFish wants to merge 7 commits into
Open
NanShanFish wants to merge 7 commits into
NanShanFish wants to merge 7 commits into
Conversation
|
Hi! I found that editing custom fields always fails on this branch (names are compared while still encrypted), and opened a PR against your branch with a fix plus a few related improvements: NanShanFish#1. Tested against a real vault. Hope it helps get this merged! |
- fix custom field edits: names were compared against the encrypted field names, so no custom field could ever match - prefer exact, then unique case-insensitive, then unique substring matches; error on ambiguity instead of editing the first hit - fall back to custom fields for built-in names that don't apply to the entry type (e.g. 'password' on a secure note), like 'rbw get --field' - add --create to add a missing custom field as a hidden field - take piped values verbatim (keep lines starting with '#', trim only a single trailing newline)
edit --field: fix custom field edits, exact matching, --create, verbatim stdin
pschmitt
added a commit
to pschmitt/rbw
that referenced
this pull request
Oct 15, 2026
The value comes from piped stdin (rbw edit --field token ENTRY <<< value) or from $EDITOR prefilled with the current value, and is saved through rbw set, so keyed entries, password history and revision checks behave the same. Built-in fields (name, username, password, notes, totp, uris) win over custom fields of the same name, as in rbw get --field; a missing custom field is created as hidden. Ported from doy#367. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Add
--fieldtorbw edit, matchingrbw get --field. See #365.Currently
rbw editcan only edit password + notes; this lets users edit asingle field (username, name, notes, password, totp, uris, or a custom field)
from the CLI.
Depends on #366 (editing keyed entries must encrypt with the item key and send
the
keyfield, so this branch is based on that fix).Changes
src/bin/rbw/main.rs: add-f/--fieldto the Edit subcommandsrc/bin/rbw/commands.rs:editintoedit_default(existing password + notes flow) andedit_field(single-field flow)edit_field: open the editor with the current plaintext value -> parse viaparse_field_value-> encrypt with the entry key (org / item key) -> updatethe field -> PUT
into history), totp, uris (one per line, preserving existing per-URI match
types by plaintext match), custom fields (matched by name substring)
not available on the entry type
parse_field_valuehelper with unit testsUsage
Testing
cargo test(all targets) passescargo fmt/cargo clippy --all-targetscleanFixes #365