CHINA-495: Add custom TLS certificate for clickhouse #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianton-ru
changed the title
|
jfyi, you can create draft PRs that won't call reviewers immediately |
ianton-ru
force-pushed
the
CHINA-495
branch
9 times, most recently
from
e93f9fe to
54aaeef
Compare
ianton-ru
force-pushed
the
CHINA-495
branch
from
54aaeef to
dfe9a53
Compare
ianton-ru
changed the title
epikhinm
reviewed
Sep 24, 2024
| } | ||
|
|
||
| certificate := types.StringValue(certRaw) | ||
| s, err := strconv.Unquote(oldKey) |
There was a problem hiding this comment.
I suppose we need to be able to support multiple formats here, or describe which format of keys we support.
There was a problem hiding this comment.
Most of users will use file [1] function to forward keys, it's gonna be unquoted for most of cases.
[1] https://developer.hashicorp.com/terraform/language/functions/file
There was a problem hiding this comment.
Works as with
key = file("server.key")
as well as with
key = <<EOT
-----BEGIN CERTIFICATE-----
....
-----END CERTIFICATE-----
EOT
ianton-ru
commented
Sep 24, 2024
| Read-Only: | ||
|
|
||
| - `certificate` (String) Public certificate | ||
| - `key` (String) Private certificate key |
There was a problem hiding this comment.
Without key can't check changes in private part
For example if customer used at first time wrong private part, changing in private part is not detected withoput changing in public part (certificate).
ianton-ru
force-pushed
the
CHINA-495
branch
from
37b9f86 to
69c0565
Compare
ianton-ru
force-pushed
the
CHINA-495
branch
3 times, most recently
from
4cc0725 to
248de08
Compare
ianton-ru
force-pushed
the
CHINA-495
branch
from
248de08 to
e26b191
Compare
ianton-ru
force-pushed
the
CHINA-495
branch
2 times, most recently
from
501cc61 to
c0f612c
Compare
ianton-ru
force-pushed
the
CHINA-495
branch
from
c0f612c to
c756f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.