Bug fixes for Orleans Bank Account sample. #7019
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balance now updates after Deposit or Withdraw operations. Withdraw decrements now instead of incorrectly incrementing.
|
Removing the immutability of the Balance class sets a bad precedent for this sample. The idea of immutability is to prevent the class of bugs where grain A makes a change to a instance, then sends it to grain B -- on the same silo -- and then makes another change to the instance, which, because it's a reference/byref, will change the instance in grain B also. |
ReubenBond
approved these changes
May 8, 2025
ReubenBond
reviewed
May 8, 2025
| @@ -34,7 +34,7 @@ public Task Withdraw(int amount) => | |||
| $" This account has {balance.Value} credits."); | |||
| } | |||
|
|
|||
| return balance with { Value = balance.Value + amount }; | |||
| balance = balance.Value -= amount; | |||
There was a problem hiding this comment.
The balance = part here is unnecessary - the balance variable goes out of scope immediately after this statement
|
@oising I believe this is the correct change, due to how the transactions API works: The delegate passed to PerformUpdate receives a copy of state and it's expected to mutate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Balance now updates after Deposit or Withdraw operations.
Withdraw decrements now instead of incorrectly incrementing.