Treat SYSLIB1092 as error in sources

src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeModuleBuilder.cs

@@ -113,7 +113,7 @@ private int GetMemberRef(Module? refedModule, int tr, int defToken)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_GetMemberRefFromSignature", StringMarshalling = StringMarshalling.Utf16)]
-        private static partial int GetMemberRefFromSignature(QCallModule module, int tr, string methodName, byte[] signature, int length);
+        private static partial int GetMemberRefFromSignature(QCallModule module, int tr, string methodName, [In] byte[] signature, int length);
 
         private int GetMemberRefFromSignature(int tr, string methodName, byte[] signature, int length)
         {
@@ -156,7 +156,7 @@ private int GetMemberRefOfFieldInfo(int tkType, RuntimeTypeHandle declaringType,
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_GetTokenFromTypeSpec")]
-        private static partial int GetTokenFromTypeSpec(QCallModule pModule, byte[] signature, int length);
+        private static partial int GetTokenFromTypeSpec(QCallModule pModule, [In] byte[] signature, int length);
 
         private int GetTokenFromTypeSpec(byte[] signature, int length)
         {
@@ -165,13 +165,13 @@ private int GetTokenFromTypeSpec(byte[] signature, int length)
         }
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_GetArrayMethodToken", StringMarshalling = StringMarshalling.Utf16)]
-        private static partial int GetArrayMethodToken(QCallModule module, int tkTypeSpec, string methodName, byte[] signature, int sigLength);
+        private static partial int GetArrayMethodToken(QCallModule module, int tkTypeSpec, string methodName, [In] byte[] signature, int sigLength);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_GetStringConstant", StringMarshalling = StringMarshalling.Utf16)]
         private static partial int GetStringConstant(QCallModule module, string str, int length);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ModuleBuilder_SetFieldRVAContent")]
-        internal static partial void SetFieldRVAContent(QCallModule module, int fdToken, byte[]? data, int length);
+        internal static partial void SetFieldRVAContent(QCallModule module, int fdToken, [In] byte[]? data, int length);
 
         #endregion
 

src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeTypeBuilder.cs

@@ -66,23 +66,23 @@ public void Bake(RuntimeModuleBuilder module, int token)
 
         #region Internal Static FCalls
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineMethod", StringMarshalling = StringMarshalling.Utf16)]
-        internal static partial int DefineMethod(QCallModule module, int tkParent, string name, byte[] signature, int sigLength,
+        internal static partial int DefineMethod(QCallModule module, int tkParent, string name, [In] byte[] signature, int sigLength,
             MethodAttributes attributes);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineMethodSpec")]
-        internal static partial int DefineMethodSpec(QCallModule module, int tkParent, byte[] signature, int sigLength);
+        internal static partial int DefineMethodSpec(QCallModule module, int tkParent, [In] byte[] signature, int sigLength);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineField", StringMarshalling = StringMarshalling.Utf16)]
-        internal static partial int DefineField(QCallModule module, int tkParent, string name, byte[] signature, int sigLength,
+        internal static partial int DefineField(QCallModule module, int tkParent, string name, [In] byte[] signature, int sigLength,
             FieldAttributes attributes);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_SetMethodIL")]
         private static partial void SetMethodIL(QCallModule module, int tk, [MarshalAs(UnmanagedType.Bool)] bool isInitLocals,
-            byte[]? body, int bodyLength,
-            byte[] LocalSig, int sigLength,
+            [In] byte[]? body, int bodyLength,
+            [In] byte[] LocalSig, int sigLength,
             int maxStackSize,
-            ExceptionHandler[]? exceptions, int numExceptions,
-            int[]? tokenFixups, int numTokenFixups);
+            [In] ExceptionHandler[]? exceptions, int numExceptions,
+            [In] int[]? tokenFixups, int numTokenFixups);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineCustomAttribute")]
         private static partial void DefineCustomAttribute(QCallModule module, int tkAssociate, int tkConstructor,
@@ -97,7 +97,7 @@ internal static void DefineCustomAttribute(RuntimeModuleBuilder module, int tkAs
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineProperty", StringMarshalling = StringMarshalling.Utf16)]
         internal static partial int DefineProperty(QCallModule module, int tkParent, string name, PropertyAttributes attributes,
-            byte[] signature, int sigLength);
+            [In] byte[] signature, int sigLength);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineEvent", StringMarshalling = StringMarshalling.Utf16)]
         internal static partial int DefineEvent(QCallModule module, int tkParent, string name, EventAttributes attributes, int tkEventType);
@@ -117,7 +117,7 @@ internal static partial int SetParamInfo(QCallModule module, int tkMethod, int i
             ParameterAttributes iParamAttributes, string? strParamName);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_GetTokenFromSig")]
-        internal static partial int GetTokenFromSig(QCallModule module, byte[] signature, int sigLength);
+        internal static partial int GetTokenFromSig(QCallModule module, [In] byte[] signature, int sigLength);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_SetFieldLayoutOffset")]
         internal static partial void SetFieldLayoutOffset(QCallModule module, int fdToken, int iOffset);
@@ -535,11 +535,11 @@ protected override bool IsCreatedCore()
         #region FCalls
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineType", StringMarshalling = StringMarshalling.Utf16)]
         private static partial int DefineType(QCallModule module,
-            string fullname, int tkParent, TypeAttributes attributes, int tkEnclosingType, int[] interfaceTokens);
+            string fullname, int tkParent, TypeAttributes attributes, int tkEnclosingType, [In] int[] interfaceTokens);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_DefineGenericParam", StringMarshalling = StringMarshalling.Utf16)]
         private static partial int DefineGenericParam(QCallModule module,
-            string name, int tkParent, GenericParameterAttributes attributes, int position, int[] constraints);
+            string name, int tkParent, GenericParameterAttributes attributes, int position, [In] int[] constraints);
 
         [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "TypeBuilder_TermCreateClass")]
         private static partial void TermCreateClass(QCallModule module, int tk, ObjectHandleOnStack type);

src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs

@@ -1773,7 +1773,7 @@ public bool Equals(ModuleHandle handle)
         private static partial void GetDynamicMethod(
             QCallModule module,
             string name,
-            byte[] sig,
+            [In] byte[] sig,
             int sigLen,
             ObjectHandleOnStack resolver,
             ObjectHandleOnStack result);

src/libraries/Common/src/Interop/Interop.Calendar.cs

@@ -10,7 +10,7 @@ internal static partial class Interop
     internal static partial class Globalization
     {
         [LibraryImport(Libraries.GlobalizationNative, EntryPoint = "GlobalizationNative_GetCalendars", StringMarshalling = StringMarshalling.Utf16)]
-        internal static partial int GetCalendars(string localeName, CalendarId[] calendars, int calendarsCapacity);
+        internal static partial int GetCalendars(string localeName, [Out] CalendarId[] calendars, int calendarsCapacity);
 
         [LibraryImport(Libraries.GlobalizationNative, EntryPoint = "GlobalizationNative_GetCalendarInfo", StringMarshalling = StringMarshalling.Utf16)]
         internal static unsafe partial ResultCode GetCalendarInfo(string localeName, CalendarId calendarId, CalendarDataType calendarDataType, char* result, int resultCapacity);

src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetUnixVersion.cs

@@ -12,7 +12,7 @@ internal static partial class Interop
     internal static partial class Sys
     {
         [LibraryImport(Libraries.SystemNative, EntryPoint = "SystemNative_GetUnixVersion", StringMarshalling = StringMarshalling.Utf8, SetLastError = true)]
-        private static partial int GetUnixVersion(byte[] version, ref int capacity);
+        private static partial int GetUnixVersion([Out] byte[] version, ref int capacity);
 
         internal static string GetUnixVersion()
         {

src/libraries/Common/src/Interop/Windows/Advapi32/Interop.CreateWellKnownSid.cs

@@ -15,8 +15,8 @@ internal static partial class Advapi32
         [LibraryImport(Libraries.Advapi32, SetLastError = true)]
         internal static partial int CreateWellKnownSid(
             int sidType,
-            byte[]? domainSid,
-            byte[] resultSid,
+            [In] byte[]? domainSid,
+            [Out] byte[] resultSid,
             ref uint resultSidLength);
 
         [LibraryImport(Libraries.Advapi32, SetLastError = true)]

src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegEnumKeyEx.cs

@@ -18,9 +18,9 @@ internal static unsafe partial int RegEnumKeyEx(
             int dwIndex,
             ref char lpName,
             ref int lpcbName,
-            int[]? lpReserved,
+            [In] int[]? lpReserved,
             [Out] char[]? lpClass,
-            int[]? lpcbClass,
-            long[]? lpftLastWriteTime);
+            [In, Out] int[]? lpcbClass,
+            [Out] long[]? lpftLastWriteTime);
     }
 }

src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegEnumValue.cs

@@ -20,8 +20,8 @@ internal static partial int RegEnumValue(
             [Out] char[] lpValueName,
             ref int lpcbValueName,
             IntPtr lpReserved_MustBeZero,
-            int[]? lpType,
-            byte[]? lpData,
-            int[]? lpcbData);
+            [Out] int[]? lpType,
+            [Out] byte[]? lpData,
+            [In, Out] int[]? lpcbData);
     }
 }

src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegQueryValueEx.cs

@@ -16,9 +16,9 @@ internal static partial class Advapi32
         internal static partial int RegQueryValueEx(
             SafeRegistryHandle hKey,
             string? lpValueName,
-            int[]? lpReserved,
+            [In] int[]? lpReserved,
             ref int lpType,
-            byte[]? lpData,
+            [Out] byte[]? lpData,
             ref int lpcbData);
 
         [LibraryImport(Libraries.Advapi32, EntryPoint = "RegQueryValueExW", StringMarshalling = StringMarshalling.Utf16)]

src/libraries/Common/src/Interop/Windows/Advapi32/Interop.RegSetValueEx.cs

@@ -18,7 +18,7 @@ internal static partial int RegSetValueEx(
             string? lpValueName,
             int Reserved,
             int dwType,
-            byte[]? lpData,
+            [In] byte[]? lpData,
             int cbData);
 
         [LibraryImport(Libraries.Advapi32, EntryPoint = "RegSetValueExW", StringMarshalling = StringMarshalling.Utf16)]
@@ -27,7 +27,7 @@ internal static partial int RegSetValueEx(
             string? lpValueName,
             int Reserved,
             int dwType,
-            char[]? lpData,
+            [In] char[]? lpData,
             int cbData);
 
         [LibraryImport(Libraries.Advapi32, EntryPoint = "RegSetValueExW", StringMarshalling = StringMarshalling.Utf16)]

src/libraries/Common/src/Interop/Windows/OleAut32/Interop.SysAllocStringByteLen.cs

@@ -9,6 +9,6 @@ internal static partial class Interop
     internal static partial class OleAut32
     {
         [LibraryImport(Libraries.OleAut32)]
-        internal static partial IntPtr SysAllocStringByteLen(byte[]? str, uint len);
+        internal static partial IntPtr SysAllocStringByteLen([In] byte[]? str, uint len);
     }
 }