Disable part of nopiatest on interpreter #121147
Open
+31
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting a platform which doesn't support varargs
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR adds platform detection to skip vararg tests (Test9 and Test10) on platforms that don't support varargs in the NoPIA type equivalence test suite.
Key Changes
- Added TestLibrary reference to the project for accessing PlatformDetection
- Added conditional execution logic to skip Test9 and Test10 when varargs are not supported
- Updated branch instructions from short form (
br.s) to regular form (br) to accommodate longer jump distances
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nopiatestil.ilproj | Added TestLibrary project reference for platform detection |
| nopiatestil.il | Added assembly reference, conditional test execution for vararg tests, and updated branch instructions for correct jump distances |
| call bool [TestLibrary]TestLibrary.PlatformDetection::get_IsVarArgSupported() | ||
| brfalse.s IL_SkipVarArgsTests_9 | ||
|
|
||
| call void NoPIATest.Program::Test9() |
There was a problem hiding this comment.
Inconsistent indentation: the call to Test9() at line 1049 has extra leading whitespace compared to the call to get_IsVarArgSupported() at line 1046. Both should have the same indentation level for IL code consistency.
Suggested change
| call void NoPIATest.Program::Test9() | |
| call void NoPIATest.Program::Test9() |
Comment on lines
+1049
to
+1055
| call void NoPIATest.Program::Test9() | ||
| IL_SkipVarArgsTests_9: nop | ||
| IL_00bb: br IL_00e5 | ||
| IL_00bd: | ||
| call bool [TestLibrary]TestLibrary.PlatformDetection::get_IsVarArgSupported() | ||
| brfalse.s IL_SkipVarArgsTests_10 | ||
| call void NoPIATest.Program::Test10() |
There was a problem hiding this comment.
Inconsistent indentation: the call to Test10() at line 1055 has extra leading whitespace compared to the call to get_IsVarArgSupported() at line 1053. Both should have the same indentation level for IL code consistency.
Suggested change
| call void NoPIATest.Program::Test9() | |
| IL_SkipVarArgsTests_9: nop | |
| IL_00bb: br IL_00e5 | |
| IL_00bd: | |
| call bool [TestLibrary]TestLibrary.PlatformDetection::get_IsVarArgSupported() | |
| brfalse.s IL_SkipVarArgsTests_10 | |
| call void NoPIATest.Program::Test10() | |
| call void NoPIATest.Program::Test9() | |
| IL_SkipVarArgsTests_9: nop | |
| IL_00bb: br IL_00e5 | |
| IL_00bd: | |
| call bool [TestLibrary]TestLibrary.PlatformDetection::get_IsVarArgSupported() | |
| brfalse.s IL_SkipVarArgsTests_10 | |
| call void NoPIATest.Program::Test10() |
jkoritzinsky
approved these changes
Oct 29, 2025
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify nopiatest to not run its varargs component if the test is targetting a platform which doesn't support varargs