Add ExcludeStatics API #117905
Merged
Add ExcludeStatics API #117905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR adds an ExcludeStatics property to two code analysis attributes (RequiresDynamicCodeAttribute and RequiresUnreferencedCodeAttribute) to provide developers with fine-grained control over whether the attributes should apply to static members of a class.
Key changes:
- Adds
ExcludeStaticsboolean property to both attributes with appropriate XML documentation - Updates the reference assembly to include the new API surface
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/libraries/System.Runtime/ref/System.Runtime.cs |
Updates reference assembly to expose new ExcludeStatics property on both attributes |
src/libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/RequiresUnreferencedCodeAttribute.cs |
Implements ExcludeStatics property with XML documentation |
src/libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/RequiresDynamicCodeAttribute.cs |
Implements ExcludeStatics property with XML documentation |
...tem.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/RequiresUnreferencedCodeAttribute.cs
Outdated
Show resolved
Hide resolved
...s/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/RequiresDynamicCodeAttribute.cs
Outdated
Show resolved
Hide resolved
Doc that true means statics are excluded
This was referenced Jul 22, 2025
Open
jtschuster
approved these changes
Jul 22, 2025
|
/ba-g "timeouts" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with #117904, fixes #117524.