Update the condition GenerateTargetFrameworkMonikerAttribute #9925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9840
Context
msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets
Lines 3667 to 3689 in 9af8ff2
The condition on the target doesn't match the condition on the WriteLinesToFile task. So get this
Changes Made
Add and '$(TargetFrameworkMonikerAssemblyAttributeText)' != '' to the Condition on the Target and removing the redundant conditions on tasks