Update assembly versions to latest for packages that recently shipped #11038
Conversation
Microsoft.IO.Redist, System.Bufferes, System.Memory and more recently shipped from the dotnet/maintenance-packages repository. Update binding redirects to the latest assembly version in order for them to be available on .NET Framework msbuild. This will require coordination with VS.
src/MSBuild/app.amd64.config
Outdated
| @@ -39,8 +39,8 @@ | |||
|
|
|||
| <dependentAssembly> | |||
| <assemblyIdentity name="Microsoft.IO.Redist" culture="neutral" publicKeyToken="cc7b13ffcd2ddd51" /> | |||
| <bindingRedirect oldVersion="0.0.0.0-99.9.9.9" newVersion="6.0.0.1" /> | |||
| <codeBase version="6.0.0.1" href="..\Microsoft.IO.Redist.dll"/> | |||
| <bindingRedirect oldVersion="0.0.0.0-99.9.9.9" newVersion="6.1.0.0" /> | |||
There was a problem hiding this comment.
Do you mind explaining what this does?
There was a problem hiding this comment.
The 99 upper bound doesn't seem right here; we need to do that for MSBuild versions but I don't think it's right for IO.Redist.
|
@carlossanlop looks like we need to backport the new m-p packages from SBRP main to release/9.0 as msbuild uses SBRP 9.0. |
There was a problem hiding this comment.
This needs the same VS coordination as #11145, and I think we can slot it in right after that one (since @MarkOsborneMS has currently gotten that one working so it's first in line).
src/MSBuild/app.amd64.config
Outdated
| @@ -39,8 +39,8 @@ | |||
|
|
|||
| <dependentAssembly> | |||
| <assemblyIdentity name="Microsoft.IO.Redist" culture="neutral" publicKeyToken="cc7b13ffcd2ddd51" /> | |||
| <bindingRedirect oldVersion="0.0.0.0-99.9.9.9" newVersion="6.0.0.1" /> | |||
| <codeBase version="6.0.0.1" href="..\Microsoft.IO.Redist.dll"/> | |||
| <bindingRedirect oldVersion="0.0.0.0-99.9.9.9" newVersion="6.1.0.0" /> | |||
There was a problem hiding this comment.
The 99 upper bound doesn't seem right here; we need to do that for MSBuild versions but I don't think it's right for IO.Redist.
Microsoft.IO.Redist, System.Bufferes, System.Memory and more recently shipped from the dotnet/maintenance-packages repository. Update binding redirects to the latest assembly version in order for them to be available on .NET Framework msbuild.
This change will require coordination with VS. Even more importantly, this change also updates System.Memory which according to the documentation in Versions.props is a breaking change.