Skip to content

Commit

Permalink
[automated] Merge branch 'vs17.13' => 'main' (#11281)
Browse files Browse the repository at this point in the history
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10000931 (#10267)

* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9752299
* Increase VersionPrefix version

---------

Co-authored-by: Jenny Bai <[email protected]>

* [17.11] Fix component governance alerts (#10520)

* Resolves CG alerts
---------

Co-authored-by: Rainer Sigwald <[email protected]>

* Assembly redirect fix (#10624)

* Fixing the assembly redirect

* [vs17.11] Update dependencies from dotnet/arcade (#10654)

* Update dependencies from https://github.com/dotnet/arcade build 20240910.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24311.3 -> To Version 8.0.0-beta.24460.4

* version bump

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mariana Garces Dematte <[email protected]>

* Upgrade system.text.json to 8.0.4 (#10650)

Will address dotnet/sdk#43339 when deployed in VS.

---------

Co-authored-by: Rainer Sigwald <[email protected]>

* disable loc (#10693)

Part of: #10665

Disabling localization for 17.11.

* [vs17.11] Update dependencies from dotnet/arcade (#10691)

* [vs17.11] Update dependencies from dotnet/arcade (#10793)

* Update dependencies from https://github.com/dotnet/arcade build 20241008.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24475.3 -> To Version 8.0.0-beta.24508.1

* bump the version

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: YuliiaKovalova <[email protected]>

* CG alert cleaning on VS17.11 (#10723)

* Bump Microsoft.IO.Redist to 6.0.1
* Bump version prefix to 17.11.11

* [vs17.11] Update dependencies from dotnet/arcade (#10832)

* [vs17.11] Update dependencies from dotnet/arcade (#10895)

* [vs17.11] Update dependencies from dotnet/arcade (#10990)

* Update dependencies from https://github.com/dotnet/arcade build 20241112.12

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24525.2 -> To Version 8.0.0-beta.24562.12

* Update VersionPrefix to 17.11.16

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>

* Update dependencies from https://github.com/dotnet/arcade build 20241120.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24562.12 -> To Version 8.0.0-beta.24570.5

* Update VersionPrefix to 17.11.17

* [vs17.11] Run tests even if version is not bumped (#11060)

Backport of #11042 to vs17.11

* [vs17.11] Backport VS insertion pipeline YMLs (#11064)

Co-authored-by: Jan Provaznik <[email protected]>

* [vs17.12] Update dependencies from dotnet/arcade (#11034)

* Update dependencies from https://github.com/dotnet/arcade build 20241122.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24562.13 -> To Version 9.0.0-beta.24572.2

* Update version prefix to 17.12.14

* Update BootstrapSdkVersion

* Decreasing severity of IDE0306

* Decrease IDE0303 severity

* Update cibuild_bootstrapped_msbuild.ps1

* Update cibuild_bootstrapped_msbuild.sh

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Jan Krivanek <[email protected]>

* Final Branding (#11130)

* Bump version (#11135)

* [vs17.12] Disable 17.12 localization (#11132)

* Update .vsts-dotnet.yml

* Version bump

* [vs17.12] Bump VS and xcopy-msbuild version to 17.12.0 (#11155)

* Bump up VS version to 17.12

* Bump up xcopy-msbuild to 17.12.0

* Bump up version prefix to 17.12.21

---------

Co-authored-by: Gang Wang <[email protected]>

* [automated] Merge branch 'vs17.10' => 'vs17.11' (#11137)

* Check version bump on release branches' update

* Skip check version bump on release branch update for initial commit to release branch or the change from dotnet bot

* Remove the exception for dependencies update by dotnet-maestro[bot]

* Bump version

* [automated] Merge branch 'vs17.9' => 'vs17.10' (#10081)

* Dont ngen taskhost Fixes our lack of optprof data (#8737)

Don't ngen TaskHosts

* Bump version

* Bump version

* Update System.Security.Cryptography.Pkcs

* Bump version

* Workaround for incorrect encoding of PUA range in GB18030 Uri string (#9751)

* [release/vs17.7] Onboard 1es templates (#9924)

* bump arcade version

* bump MicrosoftNetCompilersToolsetVersion

* bump MicrosoftNetCompilersToolsetVersion

* update sha for Microsoft.Net.Compilers.Toolset

* update darc

* update arcade channel .net 8

* update arcade

* Changed pool image

---------

Co-authored-by: Forgind <[email protected]>
Co-authored-by: Jan Krivanek <[email protected]>
Co-authored-by: sujitnayak <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: Mariana Dematte <[email protected]>

* Disable localization for vs17.10 (#10269)

Co-authored-by: Rainer Sigwald <[email protected]>

* Enable private feeds for release branch (#10355)

This PR enables MSBuild to take security fixes from MSBuild dependencies.

* [vs17.10] Update dependencies from dotnet/arcade (#10809)

* Update dependencies from https://github.com/dotnet/arcade build 20241008.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24225.1 -> To Version 8.0.0-beta.24508.1

* Update Versions.props

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: YuliiaKovalova <[email protected]>

* CG alert cleaning on VS17.10 (#10724)

* Bump Microsoft.IO.Redist to 6.0.1
* Bump System.Formats.Asn1 to 8.0.1

* [vs17.10] Update dependencies from dotnet/arcade (#10833)

* [vs17.10] Update dependencies from dotnet/arcade (#10896)

* [vs17.10] Update dependencies from dotnet/arcade (#10992)

* Update dependencies from https://github.com/dotnet/arcade build 20241112.12

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24525.2 -> To Version 8.0.0-beta.24562.12

* Update VersionPrefix to 17.10.13

* Try to resolve CI issue that could not find System.Text.Json, Version=8.0.0.4

* Revert "Try to resolve CI issue that could not find System.Text.Json, Version=8.0.0.4"

This reverts commit 66381f3.

* Update dependencies from https://github.com/dotnet/arcade build 20241120.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24525.2 -> To Version 8.0.0-beta.24570.5

* Reapply "Try to resolve CI issue that could not find System.Text.Json, Version=8.0.0.4"

This reverts commit 2cffa88.

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>

* [automated] Merge branch 'vs17.8' => 'vs17.10' (#11124)

* Dont ngen taskhost Fixes our lack of optprof data (#8737)

Don't ngen TaskHosts

* Bump version

* Bump version

* Update System.Security.Cryptography.Pkcs

* Bump version

* Workaround for incorrect encoding of PUA range in GB18030 Uri string (#9751)

* [release/vs17.7] Onboard 1es templates (#9924)

* bump arcade version

* bump MicrosoftNetCompilersToolsetVersion

* bump MicrosoftNetCompilersToolsetVersion

* update sha for Microsoft.Net.Compilers.Toolset

* CG alert cleaning on VS17.8 (#10725)

* Bump Microsoft.IO.Redist to 6.0.1

* Bump System.Formats.Asn1 to 8.0.1

* Bump System.Text.Json to 8.0.0.4

* Bump the dependencies of System.Text.Json

* Add System.Formats.Asn1 8.0.1 to the pre-built exception list

* Bump version prefix to 17.8.8

* Updated System.Collection.Immutable package to v8

* Adding System.Collections.Immutable 8.0.0 to the pre-built exception list

* Updated Version.Details.xml

* [vs17.8] update arcade and fix build  (#10838)

* Update dependencies from https://github.com/dotnet/arcade build 20241008.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23425.2 -> To Version 8.0.0-beta.24508.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23423.1 -> To Version 1.0.0-beta.23475.1 (parent: Microsoft.DotNet.Arcade.Sdk

* remove BuildXL from nuget config

* compatibility suppressions

* Update dependencies from https://github.com/dotnet/arcade build 20241…

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions

 From Version 8.0.0-beta.24508.1 -> To Version 8.0.0-beta.24516.1

* include PortableRuntimeIdentifierGraph.json

* Suppress a warning IDE0305

* bump version

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <[email protected]>

* [vs17.8] Sync internal and public branches (#10858)

* Update dependencies from https://github.com/dotnet/arcade build 20241025.2 (#10894)

* [vs17.8] Update dependencies from dotnet/arcade (#10986)

* Update dependencies from https://github.com/dotnet/arcade build 20241112.12

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24525.2 -> To Version 8.0.0-beta.24562.12

* Update VersionPrefix to 17.8.11

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Surayya Huseyn Zada <[email protected]>

* Update dependencies from https://github.com/dotnet/arcade build 20241120.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24562.12 -> To Version 8.0.0-beta.24570.5

* Update VersionPrefix to 17.8.12

* [vs17.8] Backport VS insertion pipeline YMLs (#11066)

Co-authored-by: Jan Provaznik <[email protected]>

* Update .opt-prof.yml (#11112)

* [vs17.8] Fix setting package versions in VS insertion (#11103)

* fix setting package versions

* use VS branch names in servicing package decision

---------

Co-authored-by: Jan Provaznik <[email protected]>

* Update vs/msbuild version (#11115)

* Update vs/msbuild version

* Bump version

* Update xcopy-msbuild version to 17.8.5 (#11118)

* Add inter-branch merge flow file (#11123)

* Update .opt-prof.yml (#11121)

* Bump up System.Text.Json to 8.0.5 (#11134)

* Remove the change to CompatibilitySuppressions.xml

* Remove unnecessary workaround for sdk 8.0.1xx bootstrap in the branch vs17.8

* Bump up version prefix to 17.10.14

---------

Co-authored-by: Forgind <[email protected]>
Co-authored-by: Jan Krivanek <[email protected]>
Co-authored-by: sujitnayak <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Jan Provazník <[email protected]>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <[email protected]>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [vs17.10] Run tests even if version is not bumped (#11059)

Co-authored-by: Jan Provaznik <[email protected]>

* Bump up version prefix to 17.11.20

---------

Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Jan Krivanek <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: dotnet-maestro-bot <[email protected]>
Co-authored-by: Forgind <[email protected]>
Co-authored-by: sujitnayak <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: Mariana Dematte <[email protected]>
Co-authored-by: AR-May <[email protected]>
Co-authored-by: Rainer Sigwald <[email protected]>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jan Provazník <[email protected]>
Co-authored-by: Jenny Bai <[email protected]>

* [vs17.13] Update dependencies from dotnet/source-build-reference-packages (#11177)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20241219.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24604.1 -> To Version 9.0.0-alpha.1.24619.1

* Bump version prefix to 17.13.2

* Reintroduce formatting preventing unintentional interbranch flow

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Jan Krivanek <[email protected]>

* Eliminate the unnecessary change from vs17.11

* Bump up version prefix to 17.12.22

* Update SolutionPersistence version (#11188)

* Update SolutionPersistence version

* Bump version

* Update SourceBuildPrebuiltBaseline.xml

* Remove conditional reference to System.Text.Json

* Bump up version prefix to 17.13.3

* [vs17.13] Update dependencies from dotnet/arcade (#11221)

* Update dependencies from https://github.com/dotnet/arcade build 20241223.3

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.24572.2 -> To Version 9.0.0-beta.24623.3

* Update Versions.props VersionPrefix

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <[email protected]>

* Bump up version prefix to 17.13.4

* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10751309 (#11194)

Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10751309

* Remove IO.Redist from GetPathToBuildToolsFile (#11270)

Avoids microsoft/azure-pipelines-tasks#20734 by directly using `File.Exists` in codepaths that didn't use `Microsoft.IO.Redist` until 642eed5 and turn out to be critical to the current implementation of AzDO MSBuild-using tasks.

Backport of bfa266d.

* Keep the translation in the main branch

---------

Co-authored-by: dotnet bot <[email protected]>
Co-authored-by: Jenny Bai <[email protected]>
Co-authored-by: MichalPavlik <[email protected]>
Co-authored-by: Rainer Sigwald <[email protected]>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mariana Garces Dematte <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jan Provaznik <[email protected]>
Co-authored-by: Jan Krivanek <[email protected]>
Co-authored-by: dotnet-maestro-bot <[email protected]>
Co-authored-by: Forgind <[email protected]>
Co-authored-by: sujitnayak <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: AR-May <[email protected]>
Co-authored-by: Tomas Bartonek <[email protected]>
  • Loading branch information
20 people authored Jan 20, 2025
1 parent f077a17 commit d0af071
Show file tree
Hide file tree
Showing 5 changed files with 69 additions and 2 deletions.
50 changes: 50 additions & 0 deletions .vsts-dotnet-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@ trigger:
- exp/*
- vs*

variables:
- ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
- group: AzureDevOps-Artifact-Feeds-Pats
- name: cfsNugetWarnLevel
value: warn
- name: nugetMultiFeedWarnLevel
value: none
- name: NugetSecurityAnalysisWarningLevel
value: none

jobs:
- job: CheckVersionBumpOnReleaseBranches
displayName: "Check Version Bump On Release Branches"
Expand Down Expand Up @@ -65,6 +75,14 @@ jobs:
pool:
vmImage: 'windows-2022'
steps:
- ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
- task: PowerShell@2
displayName: Setup Private Feeds Credentials
inputs:
filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1
arguments: -ConfigFile $(Build.SourcesDirectory)/NuGet.config -Password $Env:Token
env:
Token: $(dn-bot-dnceng-artifact-feeds-rw)
- task: BatchScript@1
displayName: cibuild_bootstrapped_msbuild.cmd
inputs:
Expand Down Expand Up @@ -136,6 +154,14 @@ jobs:
pool:
vmImage: 'windows-2022'
steps:
- ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
- task: PowerShell@2
displayName: Setup Private Feeds Credentials
inputs:
filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1
arguments: -ConfigFile $(Build.SourcesDirectory)/NuGet.config -Password $Env:Token
env:
Token: $(dn-bot-dnceng-artifact-feeds-rw)
- task: BatchScript@1
displayName: cibuild_bootstrapped_msbuild.cmd
inputs:
Expand Down Expand Up @@ -191,6 +217,14 @@ jobs:
name: VSEngSS-MicroBuild2022-1ES
demands: agent.os -equals Windows_NT
steps:
- ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
- task: PowerShell@2
displayName: Setup Private Feeds Credentials
inputs:
filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1
arguments: -ConfigFile $(Build.SourcesDirectory)/NuGet.config -Password $Env:Token
env:
Token: $(dn-bot-dnceng-artifact-feeds-rw)
- task: BatchScript@1
displayName: cibuild.cmd
inputs:
Expand Down Expand Up @@ -265,6 +299,14 @@ jobs:
pool:
vmImage: 'ubuntu-latest'
steps:
- ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
- task: Bash@3
displayName: Setup Private Feeds Credentials
inputs:
filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.sh
arguments: $(Build.SourcesDirectory)/NuGet.config $Token
env:
Token: $(dn-bot-dnceng-artifact-feeds-rw)
- bash: . 'eng/cibuild_bootstrapped_msbuild.sh' --onlyDocChanged $(onlyDocChanged)
displayName: CI Build
- task: PublishTestResults@2
Expand Down Expand Up @@ -322,6 +364,14 @@ jobs:
pool:
vmImage: 'macOS-latest'
steps:
- ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
- task: Bash@3
displayName: Setup Private Feeds Credentials
inputs:
filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.sh
arguments: $(Build.SourcesDirectory)/NuGet.config $Token
env:
Token: $(dn-bot-dnceng-artifact-feeds-rw)
- bash: . 'eng/cibuild_bootstrapped_msbuild.sh' --onlyDocChanged $(onlyDocChanged)
displayName: CI Build
- task: PublishTestResults@2
Expand Down
15 changes: 15 additions & 0 deletions .vsts-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ variables:
value: true # Enable loc for vs17.14
- name: Codeql.Enabled
value: true
- group: AzureDevOps-Artifact-Feeds-Pats
- name: cfsNugetWarnLevel
value: warn
- name: nugetMultiFeedWarnLevel
value: none
- name: NugetSecurityAnalysisWarningLevel
value: none

resources:
repositories:
Expand Down Expand Up @@ -120,6 +127,14 @@ extends:
- task: NuGetToolInstaller@1
displayName: 'Install NuGet.exe'

- task: PowerShell@2
displayName: Setup Private Feeds Credentials
inputs:
filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1
arguments: -ConfigFile $(Build.SourcesDirectory)/NuGet.config -Password $Env:Token
env:
Token: $(dn-bot-dnceng-artifact-feeds-rw)

- task: NuGetCommand@2
displayName: Restore internal tools
inputs:
Expand Down
2 changes: 1 addition & 1 deletion eng/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ function Set-OptProfVariables() {

function Check-EditedFiles() {
# Log VSTS errors for changed lines
git --no-pager diff HEAD --unified=0 --no-color --exit-code | ForEach-Object { "##vso[task.logissue type=error] $_" }
git --no-pager diff HEAD --unified=0 --no-color --exit-code -- src/ | ForEach-Object { "##vso[task.logissue type=error] $_" }
if ($LASTEXITCODE -ne 0) {
throw "##vso[task.logissue type=error] After building, there are changed files. Please build locally and include these changes in your pull request."
}
Expand Down
3 changes: 2 additions & 1 deletion src/Shared/FrameworkLocationHelper.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
Expand Down Expand Up @@ -1390,6 +1390,7 @@ public virtual string GetPathToDotNetFramework(DotNetFrameworkArchitecture archi
// Assume if either MSBuild.exe or Microsoft.Build.dll are shipped, there is a valid install.
// Note: net481 did not ship an ARM64 MSBuild.exe, so checking its dll's is the fallback for a valid install.
// Context: https://github.com/dotnet/msbuild/pull/7689
// Rollback see https://developercommunity.visualstudio.com/t/Unable-to-locate-MSBuild-path-with-Lates/10824132
if (this._hasMsBuild &&
generatedPathToDotNetFramework != null &&
(!File.Exists(Path.Combine(generatedPathToDotNetFramework, NativeMethodsShared.IsWindows ? "MSBuild.exe" : "mcs.exe")) &&
Expand Down
1 change: 1 addition & 0 deletions src/Utilities/ToolLocationHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3584,6 +3584,7 @@ public static string GetPathToBuildToolsFile(string fileName, string toolsVersio
{
toolPath = Path.Combine(toolPath, fileName);

// Rollback see https://developercommunity.visualstudio.com/t/Unable-to-locate-MSBuild-path-with-Lates/10824132
if (!File.Exists(toolPath))
{
toolPath = null;
Expand Down

0 comments on commit d0af071

Please sign in to comment.