[runtime] Adopt safer native compiler flags: Wshadow #24088

rolfbjarne · 2025-10-23T07:58:15Z

Example warning:

macios/runtime/trampolines-invoke.m:212:15: error: declaration shadows a local variable [-Werror,-Wshadow]
  212 |                 const char *type = xamarin_skip_encoding_flags (argType);
      |                             ^

References:

https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app
https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero)

Contributes towards #23023.

Example warning: ``` macios/runtime/xamarin/runtime.h:232:14: error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers] 232 | const char * const xamarin_get_original_working_directory_path (); ``` References: * https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app * https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero) Contributes towards #23023.

Example warning: ``` In file included from macios/appex-deduplicate-frameworks/macios/runtime/runtime.m:98: macios/runtime/delegates.inc:189:41: error: missing field 'register_assembly' initializer [-Werror,-Wmissing-field-initializers] 189 | static struct Delegates delegates = { 0 }; | ^ ``` References: * https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app * https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero) Contributes towards #23023.

…atch (#24072) Example warning: ``` macios/runtime/trampolines.m:1784:9: error: cast from 'void *(*)(MonoObject *, void *, GCHandle *)' (aka 'void *(*)(_MonoObject *, void *, void **)') to 'xamarin_managed_to_id_func' (aka 'id (*)(_MonoObject *, void *, void **)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch] 1784 | return (xamarin_managed_to_id_func) xamarin_smart_enum_to_nsstring; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` References: * https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app * https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero) Contributes towards #23023.

…-body Example warning: ``` macios/runtime/shared.m:50:106: error: semicolon before method body is ignored [-Werror,-Wsemicolon-before-method-body] 50 | -(id) initWithData: (void *) targ selector:(SEL) sel argument:(id) arg is_direct_binding:(bool) is_direct; | ^ ``` References: * https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app * https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero) Contributes towards #23023.

Example warning: ``` macios/runtime/trampolines-arm64.m:214:21: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare] 214 | for (int i = 1; i < struct_length; i++) | ~ ^ ~~~~~~~~~~~~~ ``` References: * https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app * https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero) Contributes towards #23023.

This will zero-initialize all automatic (stack and register based) variables. References: * https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app * https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero) Contributes towards #23023.

Example warning: ``` macios/runtime/trampolines-invoke.m:212:15: error: declaration shadows a local variable [-Werror,-Wshadow] 212 | const char *type = xamarin_skip_encoding_flags (argType); | ^ ``` References: * https://developer.apple.com/documentation/xcode/enabling-enhanced-security-for-your-app * https://releases.llvm.org/8.0.0/tools/clang/docs/ReleaseNotes.html#major-new-features (for -ftrivial-auto-var-init=zero) Contributes towards #23023.

dalexsoto · 2025-10-23T11:56:58Z

runtime/runtime.m

-	GCHandle handle = xamarin_gchandle_new (exception, false);
-	mode = xamarin_on_marshal_managed_exception (handle, &exception_gchandle);
-	xamarin_gchandle_free (handle);
+	{
+		GCHandle handle = xamarin_gchandle_new (exception, false);
+		mode = xamarin_on_marshal_managed_exception (handle, &exception_gchandle);
+		xamarin_gchandle_free (handle);
+	}


why is this inside its own block?

It defines a local variable named "handle", and there are other locations further down in this method that do the same thing. Putting it inside its own block makes this definition separate from those definitions (which is exactly what the new warning detects).

…Wshadow

vs-mobiletools-engineering-service2 · 2025-10-27T14:49:42Z

✅ [CI Build #1b4502e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T14:52:19Z

✅ [PR Build #1b4502e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T15:19:28Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T15:24:16Z

✅ [CI Build #1b4502e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T15:36:17Z

💻 [CI Build #1b4502e] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T15:38:46Z

💻 [CI Build #1b4502e] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T15:39:11Z

💻 [CI Build #1b4502e] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T15:39:11Z

💻 [CI Build #1b4502e] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T15:40:08Z

💻 [CI Build #1b4502e] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

vs-mobiletools-engineering-service2 · 2025-10-27T16:21:44Z

🚀 [CI Build #1b4502e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 1b4502ed0af68f99954bcaecfc56e6c8cb21ab81 [PR build]

rolfbjarne added 7 commits October 22, 2025 13:46

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Oct 23, 2025

View reviewed changes

rolfbjarne changed the base branch from dev/rolf/safer-flags-ftrivial-auto-var-init-zero to main October 27, 2025 14:18

Merge remote-tracking branch 'origin/main' into dev/rolf/safer-flags-…

1b4502e

…Wshadow

rolfbjarne enabled auto-merge (squash) October 27, 2025 14:18

rolfbjarne merged commit 4bdd592 into main Oct 27, 2025
45 checks passed

rolfbjarne linked an issue Oct 28, 2025 that may be closed by this pull request

Look into new security features with Xcode 26 #23023

Closed

Uh oh!

[runtime] Adopt safer native compiler flags: Wshadow #24088

[runtime] Adopt safer native compiler flags: Wshadow #24088

Uh oh!

Conversation

rolfbjarne commented Oct 23, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

✅ [CI Build #1b4502e] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

✅ [PR Build #1b4502e] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

✅ [CI Build #1b4502e] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

💻 [CI Build #1b4502e] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

💻 [CI Build #1b4502e] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

💻 [CI Build #1b4502e] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

💻 [CI Build #1b4502e] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

💻 [CI Build #1b4502e] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 27, 2025

🚀 [CI Build #1b4502e] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants