Skip to content

Commit

Permalink
[Foundation] Fix availability attributes to be the same for all platf…
Browse files Browse the repository at this point in the history
…orms. (#17002)

Don't put availability attributes inside a platform condition, because we need
all availability attributes to be visible when building all platforms,
otherwise we won't generate the correct attributes for other platforms.
  • Loading branch information
rolfbjarne authored Dec 12, 2022
1 parent 1db1f48 commit 697a571
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/foundation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11818,29 +11818,29 @@ partial interface NSValue : NSSecureCoding, NSCopying {
[Static]
NSValue FromCGPoint (CGPoint point);

[Mac (10, 0)]
[MacCatalyst (15, 0)]
#if MONOMAC
[Mac (10,0)]
[Export ("rectValue")]
#else
[MacCatalyst (15, 0)]
[Export ("CGRectValue")]
#endif
CGRect CGRectValue { get; }

[Mac (10, 0)]
[MacCatalyst (15, 0)]
#if MONOMAC
[Mac (10,0)]
[Export ("sizeValue")]
#else
[MacCatalyst (15, 0)]
[Export ("CGSizeValue")]
#endif
CGSize CGSizeValue { get; }

[Mac (10, 0)]
[MacCatalyst (15, 0)]
#if MONOMAC
[Mac (10,0)]
[Export ("pointValue")]
#else
[MacCatalyst (15, 0)]
[Export ("CGPointValue")]
#endif
CGPoint CGPointValue { get; }
Expand Down

4 comments on commit 697a571

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 697a571a68e393b8518f068189fa74dea620a359 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 697a571a68e393b8518f068189fa74dea620a359 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent XAMMINI-053.Monterey'
Hash: 697a571a68e393b8518f068189fa74dea620a359 [CI build]

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.