Repository navigation
Bound the copies of 'when' guards in compiled pattern matches #20718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nojaf
wants to merge
7
commits into
dotnet:main
Choose a base branch
from
nojaf:pmc-guard-copy-budget
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cc2a09c
Bound the copies of 'when' guards in compiled pattern matches
nojaf fcf4f67
Add changelog
nojaf 0e77160
Don't cut matches whose guards can write the tested data
nojaf bc838ab
Merge branch 'main' into pmc-guard-copy-budget
nojaf 4551c4a
Merge remote-tracking branch 'upstream/main' into pmc-guard-copy-budget
nojaf c8c0261
Merge branch 'main' into pmc-guard-copy-budget
nojaf dd01cb0
Merge branch 'main' into pmc-guard-copy-budget
nojaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cut can still change which rule a match picks when a total active pattern reads data that a guard writes, because this arm only checks the patterns on the active pattern's result. Here is the array case from
Guards that write the tested data keep the rule the whole match would pick, with the array read through an active pattern:With this PR's build,
array [| 0; 0 |] 100returns 7 and callsElemstwice, with--optimize-and with--optimize+. The merge-base build returns -1 and callsElemsonce, as SDK 10.0.402 does. In a variant where the eightcol <= cguards call a non-inlinedle c colinstead, the merge-base build's IL has 72 calls tole. One call per guard would give 8, so that is 64 extra copies, well over this PR's budget of 32. The patterns matched against the result ofElemscontain no array, mutable field or byref, socanRetestInputallows the cut, and the rest of the match callsElemsagain, on[| 7; 7 |].The obvious fix,
TPat_query _ -> true, would also turn the cut off forhwTokenFetch, because its match uses the partialTokenRExprParen(LexFilter.fsline 1702). AnElemsvariant inguardWritesTestedDataSourcewould cover whichever fix you choose.