Repository navigation
Classify each Find All References line while the search runs - #20533
xperiandri wants to merge 3 commits into
Conversation
✅ Release notes checked
|
| @@ -48,11 +49,21 @@ module FSharpFindUsagesService = | |||
| |> Option.map (fun (definitionItem, _) -> definitionItem) | |||
| |> Option.defaultValue externalDefinitionItem | |||
There was a problem hiding this comment.
| |> Option.defaultValue externalDefinitionItem | |
| |> Array.tryFindV (snd >> (=) doc.Project.FilePath) | |
| |> ValueOption.map (fun (definitionItem, _) -> definitionItem) | |
| |> ValueOption.defaultValue externalDefinitionItem |
There was a problem hiding this comment.
Split out as #20534 — this line isn't touched by this PR.
T-Gro
left a comment
There was a problem hiding this comment.
🤖🕵️ Please shorten the description using this guidance. Focus on the problem and why the change is needed, in simplified technical English. Leave the implementation inventory to the Files tab and retain necessary caveats.
9ee88cb to
db208c0
Compare
fda5983 to
0478aa2
Compare
0478aa2 to
d3a5862
Compare
d3a5862 to
72f95e1
Compare
Build Failure AnalysisSummary - All 15 failing Windows build legs stop in Root cause: required Roslyn API has not flowedThe binlogs consistently report Affected errors
Fix attempt - blocked Delivery - none No source change was published. Reverting this call to the available two-argument constructor would discard the classified-line data and defeat the feature. The safe fix is to flow a Roslyn build containing dotnet/roslyn#85281, then rebuild; the binlogs do not establish an exact compatible package version, so changing dependency pins here would be speculative. The PR is also on a contributor fork. Checks - Build evidence
Structured data: {
"artifact_kind": "analysis",
"fix_delivery": "none",
"fix_status": "blocked",
"workflow_artifact": "build-failure-analysis"
}
|
C# and VB classify the line of each reference as they find it and hand it to Find All References. F# handed nothing, so the window asked the F# classification service for every line again after the search, one reference at a time. ClassifiedReferenceLine classifies the line the way Roslyn does for them: from the first non-whitespace character to the end of the line, semantic spans over syntactic ones, gaps filled with text. Needs the FSharpSourceReferenceItem constructor that takes the classified line, from dotnet/roslyn#85281. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
72f95e1 to
a3dc004
Compare
Find All References re-classified every F# result line after the search, one reference at a time, through the F# classification service; for closed files that could recompute a whole-file classification repeatedly. C# and VB hand over the classified line while searching. With dotnet/roslyn#85281, F# now does the same, classifying the line while the checked file is still at hand. C# and VB references are unaffected.
Draft: cannot build until dotnet/roslyn#85281 has flowed.
🤖 Generated with Claude Code