Repository navigation
Give Navigate To the counts it sorts equal F# matches by - #20532
xperiandri wants to merge 9 commits into
Conversation
✅ Release notes checked
Warning No PR link found in some release notes, please consider adding it.
|
T-Gro
left a comment
There was a problem hiding this comment.
🤖🕵️ Please shorten the description using this guidance. Focus on the problem and why the change is needed, in simplified technical English. Leave the implementation inventory to the Files tab and retain necessary caveats.
3a8db63 to
27af195
Compare
4c712fc to
537d78b
Compare
537d78b to
21ed9d9
Compare
21ed9d9 to
91ab287
Compare
This comment has been minimized.
This comment has been minimized.
Navigate To orders matches that are otherwise equal by these counts for C# and VB. NavigableItem now carries them: every curried and tupled argument of the method a declaration compiles to, without the instance and without a solitary unit argument, and its explicitly declared type parameters. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Navigate To orders matches of the same kind by the folder distance to the file being edited, then by parameter and type parameter count and name, for C# and VB. Roslyn computes the same key for F# results once they carry the counts, which NavigableItem now records. Needs the FSharpNavigateToSearchResult constructor that takes the counts, from dotnet/roslyn#85280. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Linking the note added a copy of it instead of editing the first, and `main` has since opened 11.0.200 for SDK 11.0.200, leaving 11.0.100 shipped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dotnet/roslyn#85280 takes the counts in the same constructor as whether the match kept the name's case and where in the name it landed, so the results window can highlight F# names and rank a case-exact match first. The pattern matcher reports the spans in the candidate it was given, container first, so they move to the name's own offsets; the substring fallback for operators and backticked names reports the span it found itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replaying the branch onto main left some files short of the branch's own content; this restores it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llection assert Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
b37b08d to
a88ad19
Compare
…lease note lines The branch lacked the last fix of dotnet#20531: a named unit argument of a signature (`val f: u: unit -> int`) is not a parameter. Its copy of the counts commits is also the older one. The Visual Studio release note carried an empty line and an older copy of the Find All References bullet, left by earlier union merges. The tree is now the counts PR plus the sort change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Build Failure AnalysisSummary - All failing build legs stop while compiling Root cause: Roslyn ExternalAccess API has not flowed into this buildThe 15 build logs for the primary build attempts all report the same Affected errors
Fix attempt - blocked Delivery - none The required Roslyn ExternalAccess API is unavailable in the dependencies resolved by the analyzed build. This is a Windows Visual Studio integration target, and there is no minimal change in this PR that both preserves the requested sorting data and compiles against the current five-argument contract. Checks - Build evidence
Structured data: {
"artifact_kind": "analysis",
"fix_delivery": "none",
"fix_status": "blocked",
"workflow_artifact": "build-failure-analysis"
}
|
Navigate To (Ctrl+T) listed F# matches of the same kind in no particular order, while C# and VB put matches from the current file and nearby folders first. dotnet/roslyn#85280 computes that ordering for F# too if F# supplies parameter and type parameter counts; this passes them.
Draft: cannot build until dotnet/roslyn#85280 has flowed. Stacked on #20531 (first two commits).
🤖 Generated with Claude Code