Skip to content

Give Navigate To the counts it sorts equal F# matches by - #20532

Draft
xperiandri wants to merge 9 commits into
dotnet:mainfrom
xperiandri:feature/navigate-to-sort-counts
Draft

xperiandri wants to merge 9 commits into
dotnet:mainfrom
xperiandri:feature/navigate-to-sort-counts

Conversation

@xperiandri

@xperiandri xperiandri commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Navigate To (Ctrl+T) listed F# matches of the same kind in no particular order, while C# and VB put matches from the current file and nearby folders first. dotnet/roslyn#85280 computes that ordering for F# too if F# supplies parameter and type parameter counts; this passes them.

Draft: cannot build until dotnet/roslyn#85280 has flowed. Stacked on #20531 (first two commits).

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

✅ Release notes checked


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
`src/Compiler` docs/release-notes/.FSharp.Compiler.Service/11.0.200.md No current pull request URL (#20532) found, please consider adding it
`vsintegration/src` docs/release-notes/.VisualStudio/18.vNext.md

@T-Gro T-Gro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖🕵️ Please shorten the description using this guidance. Focus on the problem and why the change is needed, in simplified technical English. Leave the implementation inventory to the Files tab and retain necessary caveats.

@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Sep 15, 2026
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch 2 times, most recently from 3a8db63 to 27af195 Compare September 26, 2026 01:01
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch 2 times, most recently from 4c712fc to 537d78b Compare October 8, 2026 01:11
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch from 537d78b to 21ed9d9 Compare October 10, 2026 22:28
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch from 21ed9d9 to 91ab287 Compare October 29, 2026 22:03
@github-actions

This comment has been minimized.

xperiandri and others added 8 commits November 5, 2026 21:03
Navigate To orders matches that are otherwise equal by these counts for C#
and VB. NavigableItem now carries them: every curried and tupled argument of
the method a declaration compiles to, without the instance and without a
solitary unit argument, and its explicitly declared type parameters.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Navigate To orders matches of the same kind by the folder distance to the
file being edited, then by parameter and type parameter count and name, for
C# and VB. Roslyn computes the same key for F# results once they carry the
counts, which NavigableItem now records.

Needs the FSharpNavigateToSearchResult constructor that takes the counts,
from dotnet/roslyn#85280.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Linking the note added a copy of it instead of editing the first, and `main` has since
opened 11.0.200 for SDK 11.0.200, leaving 11.0.100 shipped.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dotnet/roslyn#85280 takes the counts in the same constructor as whether the
match kept the name's case and where in the name it landed, so the results
window can highlight F# names and rank a case-exact match first. The pattern
matcher reports the spans in the candidate it was given, container first, so
they move to the name's own offsets; the substring fallback for operators and
backticked names reports the span it found itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replaying the branch onto main left some files short of the branch's own content; this restores it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llection assert

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch from b37b08d to a88ad19 Compare November 5, 2026 20:05
…lease note lines

The branch lacked the last fix of dotnet#20531: a named unit argument of a signature (`val f: u: unit -> int`)
is not a parameter. Its copy of the counts commits is also the older one.

The Visual Studio release note carried an empty line and an older copy of the Find All References
bullet, left by earlier union merges. The tree is now the counts PR plus the sort change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Build Failure Analysis

Summary - All failing build legs stop while compiling FSharp.Editor.fsproj because the PR calls a nine-argument FSharpNavigateToSearchResult constructor, while the resolved Roslyn ExternalAccess assembly exposes the existing five-argument constructor.

Root cause: Roslyn ExternalAccess API has not flowed into this build

The 15 build logs for the primary build attempts all report the same FS0501; their paired 15 logs compile successfully and contain no hidden failed-target or process evidence. The PR source supplies case sensitivity, matched spans, parameter count, and type-parameter count, but the referenced constructor only accepts additionalInformation, kind, matchKind, name, and navigateItem. This feature therefore depends on the corresponding Roslyn API flow; removing the four arguments would compile but would also remove the feature under review, so no repository source fix was published.

Affected errors

Fix attempt - blocked

Delivery - none

The required Roslyn ExternalAccess API is unavailable in the dependencies resolved by the analyzed build. This is a Windows Visual Studio integration target, and there is no minimal change in this PR that both preserves the requested sorting data and compiles against the current five-argument contract.

Checks - binlog-mcp binlog_errors --binlog_file <each of 30 validated binlogs> --limit 200 exited 0 for every log: 15 reported the same FS0501, and 15 reported no errors. binlog-mcp binlog_overview --binlog_file <each validated binlog> ultimately exited 0 for every log: the 15 error-bearing builds failed in FSharp.Editor.fsproj, while all 15 paired builds succeeded. Five concurrent overview calls initially exited 1 with context deadline exceeded; rerunning the same commands succeeded with exit 0. Remaining diagnostic: FS0501 at line 210 in every failing build attempt.

Build evidence
Evidence Result
Configuration Windows VS integration builds, MSBuild 18.12.2-1.26514.2
Failed target/task FSharp.Editor.fsproj / CoreCompile / Fsc
Failed build logs 15, each with the same constructor mismatch
Clean paired logs 15, each Build: SUCCEEDED, Errors: 0
Azure build build 1666635
Analysis run workflow run 42121411941

Structured data:

{
  "artifact_kind": "analysis",
  "fix_delivery": "none",
  "fix_status": "blocked",
  "workflow_artifact": "build-failure-analysis"
}

Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · copilot · gpt56 · 102 AIC · ⌖ 19.3 AIC · ⊞ 23.9K | [History]( · ◷)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants