Introduce encoded parameters #5317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated environment variable keys for apiservice bindings to use a new naming convention. Add documentation for newly created encoded parameters
16 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR updates the environment variable naming convention for API service bindings to include the protocol name (http/https) in the key structure, and adds documentation for a new encoded parameters feature.
Key changes:
- Environment variable keys for apiservice bindings now include the protocol in the path (e.g.,
services__apiservice__http__0instead ofservices__apiservice__0) - New documentation section explaining encoded parameter resources using the
annotated.stringtype with filters likeuri
| - `value` references the raw parameter value (`{parameter-name.value}`). | ||
| - `filter` names the formatter (e.g., `"uri"`, ...). | ||
| - The resource name is derived from the parameter name and format (`{parameter}-{format}-encoded`). Names are deduplicated if multiple projections share the same base. | ||
|
|
There was a problem hiding this comment.
The documentation states that names are deduplicated but doesn't explain how deduplication works or what the resulting names would look like. Consider adding an example or brief explanation of the deduplication strategy.
Suggested change
| For example, if multiple projections would result in the same base name, a numeric suffix is appended to ensure uniqueness (for example, `redis-password-uri-encoded`, `redis-password-uri-encoded-1`, `redis-password-uri-encoded-2`, etc.). |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
@copilot update to mention it's using {format} to deduplicate
Co-authored-by: Copilot <[email protected]>
IEvangelist
approved these changes
Oct 21, 2025
|
@IEvangelist just forgot that I should instead target release/13, correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated environment variable keys for apiservice bindings to use a new naming convention. Add documentation for newly created encoded parameters
Pending code-review in corresponding PR and potential schema changes
Internal previews