-
Notifications
You must be signed in to change notification settings - Fork 167
Add Python templates and onboarding documentation #5304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-13
Are you sure you want to change the base?
Conversation
Co-authored-by: IEvangelist <[email protected]>
Co-authored-by: IEvangelist <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... this is an okay start, but we really need to pivot. We're trying to avoid dotnetcli
commands and instead directing users to use the Aspire CLI. Also, all lists need to have complete sentences and proper punctuation.
- **Aspire Python App**: A full-stack Aspire application with a Python backend and JavaScript frontend. This template includes: | ||
|
||
- [**AspireSample.AppHost**](#app-host): An orchestrator project to connect and configure services. | ||
- [**AspireSample.ServiceDefaults**](#service-defaults): A shared project for common configurations. | ||
- **AspireSample.Backend**: A Python backend using FastAPI framework with OpenTelemetry instrumentation. | ||
- **AspireSample.Frontend**: A JavaScript frontend using React framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. The template doesn't include service defaults, and the folders are named differently. Also, it's using file-based apps with a single apphost.cs file, please refer to https://github.com/dotnet/aspire/tree/main/src/Aspire.ProjectTemplates/templates/aspire-py-starter/13.0 for details. Please link to React and FastAPI when mentioning those techs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit. Updated the template description to reflect the actual structure:
- Uses file-based AppHost with apphost.cs
- Folders are named "app" and "frontend" (not AspireSample.Backend/Frontend)
- No ServiceDefaults included
- Added links to FastAPI and React documentation
Hey @copilot please address all feedback |
This is going to be in sync with the new python integration and assets right? |
dotnet new aspire-starter | ||
``` | ||
|
||
To create an Aspire app with a Python backend and JavaScript frontend: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be using aspire new not dotnet new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I have it going to work... see #5304 (review)
…ructure Co-authored-by: IEvangelist <[email protected]>
Fixed in commit 70d2439. Updated all dotnetcli commands to use Aspire CLI (
All feedback addressed in commit 70d2439:
|
Co-authored-by: IEvangelist <[email protected]>
Overview
This PR addresses issue #5151 by providing comprehensive documentation for Python developers using Aspire, covering two main scenarios:
Changes
New Documentation: Build an Aspire app with Python and JavaScript
Created
docs/get-started/build-aspire-python-app.md
to document theaspire-py-starter
template that creates a full-stack solution with:apphost.cs
file for orchestrationThe article includes:
aspire new aspire-py-starter
app
andfrontend
folders)aspire run
Note: The article clearly indicates the template is under development (tracking issue dotnet/aspire#11865) and provides alternative guidance for current users.
Enhanced Documentation: Orchestrate Python apps in Aspire
Updated
docs/get-started/build-aspire-apps-with-python.md
to focus specifically on onboarding existing Python applications:Updated Template Documentation
Modified
docs/fundamentals/aspire-sdk-templates.md
to include the Python template:aspire new aspire-py-starter
Updated Table of Contents
Modified
docs/toc.yml
to organize Python documentation with nested structure:Documentation Quality
aspire new
,aspire run
) instead of dotnetcliai-usage: ai-assisted
metadata per guidelinesRelated Issues
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews