[build] Relax 16k native library alignment checks #10608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #10601 Android allows libraries aligned to at least 16k, as long as they are aligned to a power of two. Follow suit.
| // | ||
| // https://android.googlesource.com/platform//system/extras/+/3c784e9fd9f4e3f8e363a023939567c41c19d634%5E%21/#F0 | ||
| // | ||
| if (segment64.Alignment >= pageSize && (segment64.Alignment % 2 == 0)) { |
Member
There was a problem hiding this comment.
Is it possible for a number like 4 or 8 (kb) to come in as the page size? And that wouldn't be 16kb?
Member
There was a problem hiding this comment.
(discussed in meeting) as-is might be fine, actually checking >= 16kb makes it more complicated for 32-bit
Contributor
Author
|
The MAUI integration lane is broken across all the PRs, I'm going to merge this PR because all |
jonathanpeppers
pushed a commit
that referenced
this pull request
Nov 25, 2025
Fixes: #10601 Context: https://android.googlesource.com/platform//system/extras/+/3c784e9fd9f4e3f8e363a023939567c41c19d634%5E%21/#F0 For 64-bit native libraries Android allows the alignment to be 16k at the minimum, with any higher value acceptable as long as it's a power of two. With this commit we follow suit, accepting the same set of values as Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10601
Context: https://android.googlesource.com/platform//system/extras/+/3c784e9fd9f4e3f8e363a023939567c41c19d634%5E%21/#F0
For 64-bit native libraries Android allows the alignment to be 16k at the minimum,
with any higher value acceptable as long as it's a power of two.
With this commit we follow suit, accepting the same set of values as Android.