Skip to content

Update functional.scaled_dot_product_attention signature/arguments #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update functional.scaled_dot_product_attention signature/arguments #1473

wants to merge 1 commit into from

Conversation

DillionLowry
Copy link

  • Add optional scale and enable_gqa arguments to torch.nn.functional.scaled_dot_product_attention. Default values scale = null and enable_gqa = false match pytorch.

Breaking Change:

  • torch.nn.functional.scaled_dot_product_attention's function signature has been changed. The is_casual argument has been renamed to is_causal to match pytorch.

@DillionLowry
Copy link
Author

@dotnet-policy-service agree

@DillionLowry
Copy link
Author

@ozanMSFT Would you be willing to review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DillionLowry