Provide error code on promise rejections (fixes #1303) #1304
+35
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Life savior! |
|
Any chance this PR can get approved and a release rolled out? This is a pretty significant issue for anyone using characteristic monitoring. |
|
@PatrickDench Feels like the maintainers and contributors don’t really care about keeping this library alive anymore. |
|
+1 |
|
I have the same problem and need the fix |
|
Thanks for the temporary solution, I do need this one too ! |
2 tasks
|
Same issue. Claude implemented the patch before I found this fix :) |
|
Note that (until this gets merged) you can simply install b1naryth1ef's repo via: npm install --save https://github.com/b1naryth1ef/react-native-ble-plx.git#fix/promise-rejection |
|
FYI. As I'm actively using this library I've been actively working on bringing it up to date to React Native 0.81 / Expo 54. I have a branch in progress, but my released 3.5.4 version already also include those fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just an extension of the fix posted in #1303 as it seems modern versions of React Native don't like the null string passed here and crash. For whatever reason the repository isn't in a state where it's possible to depend on it directly (e.g. via a local filesystem dependency or a github dependency) so I had to fork and publish the package separately to NPM for testing. At least on my small application it fixed the few crashes I was seeing and didn't cause any other noticable issues.