Remove borrow on node.send_output for python
#753
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to include commits of other PRs |
This is a bit misleading, the race condition is that concurrent operations are not allowed right now. This PR removes that limitation. Perhaps you could clarify this in the PR description? |
phil-opp
reviewed
Jan 15, 2025
| @@ -41,7 +41,7 @@ impl<T> DelayedCleanup<T> { | |||
| CleanupHandle(self.0.clone()) | |||
| } | |||
|
|
|||
| pub fn get_mut(&mut self) -> std::sync::MutexGuard<T> { | |||
| pub fn get_mut(&self) -> std::sync::MutexGuard<T> { | |||
There was a problem hiding this comment.
This will still error when used concurrently. So the error just happens in a different place now, but concurrent operations are still not possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a borrow on send that should make it less adverse to race conditions.
This however still has some issues when concurrently receiving and sending.
See: #746