React-js: Add OCR demonstration #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
react-js/src/service/ImageUtils.ts:95
- [nitpick] The function name 'uuidV4' differs from the previously used 'uuidv4' casing; ensure consistency with the rest of the codebase if this function is used elsewhere.
private static uuidV4() {
ildar-scanbot
requested changes
Apr 28, 2025
| // Scanbot SDK functions return raw pixel data. Images should be encoded it as jpegs before saving or displaying them. | ||
| const jpeg = await SBSDKService.SDK.imageToJpeg(cropped); | ||
| console.log("Done processing image: ", jpeg); | ||
|
|
||
| const engine = await SBSDKService.SDK.createOcrEngine(); |
There was a problem hiding this comment.
I don't think we need to add the OCR here as it will delay the process for no reason in the "default" use case. We better extract it to a separate button or so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.