Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustls feature #124

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Fix rustls feature #124

merged 1 commit into from
Nov 17, 2024

Conversation

reneklacan
Copy link
Contributor

No description provided.

@dongri
Copy link
Owner

dongri commented Nov 15, 2024

@reneklacan What will change with this modification? In what situations were you troubled?

@reneklacan
Copy link
Contributor Author

@dongri sorry for not adding clarification

I previously added rustls feature to support building without native-tls (it's useful for building minimal few MB docker images via https://github.com/clux/muslrust for example)

With you recently adding tokio-tungstenite with native-tls feature, rustls flag no longer worked as expected as it would include both native-tls and rustls with rustls flag.

My change is not affecting default usage in any way, it is just fixing usage with rustls feature (it's making sure tokio-tungstenite is used with rustls-tls-webpki-roots in that case instead of native-tls)

@reneklacan
Copy link
Contributor Author

I will add that it's generally good practice for rust libraries to support nativetls and rustls. Many people prefer rustls for minimalism and performance.

@dongri dongri merged commit 7317831 into dongri:main Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants