Skip to content

Add ROWS FROM table function support #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
myers wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add ROWS FROM table function support #3412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2269f
Add ROWS FROM table function support
myers Feb 1, 2026
0669548
Generalize buildTableFunc for nameless TableFuncExpr and remove RowsFrom
myers Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions sql/planbuilder/from.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,15 @@ func (b *Builder) resolveTable(tab, db string, asOf interface{}) *plan.ResolvedT
return plan.NewResolvedTable(table, database, asOf)
}

// BuildMultiExprTableFunc is a factory for creating plan nodes from nameless
// TableFuncExpr (ROWS FROM pattern). Overridden by Doltgres.
var BuildMultiExprTableFunc = func(
exprs []sql.Expression, alias string,
withOrdinality bool, columnAliases []string,
) (sql.Node, error) {
return nil, sql.ErrUnsupportedFeature.New("ROWS FROM / multi-expression table functions")
}

func (b *Builder) buildTableFunc(inScope *scope, t *ast.TableFuncExpr) (outScope *scope) {
//TODO what are valid mysql table arguments
args := make([]sql.Expression, 0, len(t.Exprs))
Expand All @@ -470,6 +479,41 @@ func (b *Builder) buildTableFunc(inScope *scope, t *ast.TableFuncExpr) (outScope
}
}

// Nameless table function (ROWS FROM pattern) — delegate to factory
if t.Name == "" {
alias := t.Alias.String()
columnAliases := columnsToStrings(t.Columns)
node, err := BuildMultiExprTableFunc(args, alias, t.WithOrdinality, columnAliases)
if err != nil {
b.handleErr(err)
}
tidNode, ok := node.(plan.TableIdNode)
if !ok {
b.handleErr(fmt.Errorf("BuildMultiExprTableFunc must return a TableIdNode"))
}

outScope = inScope.push()
outScope.ast = t

name := alias
if name == "" {
name = "rows_from"
}

tabId := outScope.addTable(name)
var colset sql.ColSet
for _, c := range tidNode.Schema() {
id := outScope.newColumn(scopeColumn{
table: name,
col: c.Name,
typ: c.Type,
})
colset.Add(sql.ColumnId(id))
}
outScope.node = tidNode.WithColumns(colset).WithId(tabId)
return
}

utf := expression.NewUnresolvedTableFunction(t.Name, args)

tableFunction, found := b.cat.TableFunction(b.ctx, utf.Name())
Expand Down Expand Up @@ -529,6 +573,11 @@ func (b *Builder) buildTableFunc(inScope *scope, t *ast.TableFuncExpr) (outScope
}
}

// Apply column aliases if provided
if len(t.Columns) > 0 {
b.renameSource(outScope, "", columnsToStrings(t.Columns))
}

tabId := outScope.addTable(name)
var colset sql.ColSet
for _, c := range newAlias.Schema() {
Expand Down Expand Up @@ -911,3 +960,4 @@ func (b *Builder) bindOnlyWithDatabase(db sql.Database, stmt ast.Statement, s st
b.currentDatabase = db
return b.BindOnly(stmt, s, nil)
}