-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode Support #140
base: stable
Are you sure you want to change the base?
Dark Mode Support #140
Conversation
sition with mobile view and desktop view
…/sun icon. link cs s and js file
Uploading some screenshots for reference. A local version with just the plain html, css, and js can be found here |
Why orange? |
Its the color invert (inverted color) of the Dolphin blue logo. I think it gives the dark mode its own unique flare but, changing this back to the classic blue would be very easy and do-able if preferred! |
Definitely would be preferred. We use blue everywhere already, plus... bright orange on black is rather piercing imo. |
I went and reverted the color changes from orange to the original blue. I have attached some screenshots for reference. I haven't updated the pull request since the original blue in dark mode doesn't have the best color contrast and dark mode experience (imo). I will try to select a more "dark friendly" blue color scheme/theme that aligns to the original design. After which I will add more screenshots for reference and update the pull requests |
…ake links on darker backgrounds lighter for contrast. Remove btn-info styling
… the dark/light icons Add spacing between the light/dark mode toggle icons and the hamburger mobile toggle. For mobile view specifically.
After second review, the original blue looked perfectly fine for dark mode. Smaller additional edits have been made for quality of life. These are:
The code has been updated/pushed to the pull request. Dark mode looks very similar to the most recent changes above in which dark mode was reverted to blue. I will add one or two screenshots below to reflect the new changes. |
This looks great, and I'm picky with dark mode :P For comparison, here's Dark Reader's automatic dark mode: The native dark mode is almost always better than that too. |
Hey there Dolphin team!
I figured it was time that the Dolphin site had a dark/light mode toggle so I took a stab at it.
These changes include:
Notes:
Per the contributing instructions, the static and media file paths appear to be overwritten in Django. I'm not sure if this will occur but, I imagine it is possible that the added css and js href/script tag sources may be off in other people's environment. If so, let me know and I will take a look at fixing and providing screen shots so people can get an idea of what was changed
I am able to test css edits on dolphin pages hosted publicly (using chrome dev tools) but, was unable to test some locally due to database limitations/Django db connections that appear to be outside my control.
Thank you!
BasketballForce