Fix compatibility with IDA 7.x and Python 3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parlane
reviewed
Jul 13, 2021
leoetlino
added a commit
to leoetlino/gcdsp-ida
that referenced
this pull request
Jul 14, 2021
See discussion here: dolphin-emu#1 (comment)
leoetlino
force-pushed
the
ida7-and-python3-compat
branch
from
6c3d741 to
80014ed
Compare
leoetlino
force-pushed
the
ida7-and-python3-compat
branch
from
188f95e to
3c8d3d7
Compare
Tilka
reviewed
Jul 26, 2021
| ua_dodata2(0, op.addr, op.dtyp) | ||
| ua_add_dref(0, op.addr, dr_R) # TODO: dr_W ? | ||
| cmd.create_op_data(op.addr, 0, op.dtype) | ||
| cmd.add_dref(op.addr, 0, dr_R) |
There was a problem hiding this comment.
The TODO is still valid. Currently all xrefs are reads.
Tilka
reviewed
Jul 26, 2021
| res.dtyp = dt_byte | ||
| res.addr = val | ||
| res.dtype = dt_byte | ||
| res.addr = 0x10000 | val |
There was a problem hiding this comment.
Please add to the readme how the segments should be set up so that this works. (For a future PR, could the plugin do that itself?)
|
Not sure if this is a new bug but gcdsp-ida is missing operands sometimes. dsptool: gcdsp-ida: |
|
Yeah, looks like that could be a regression... I'll investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.