Skip to content

Commit

Permalink
Pull in CMPAR disassembly fix from Dolphin.
Browse files Browse the repository at this point in the history
The two operand register selection bits were swapped for that instruction. For
example, "CMPAR AC1, AX0.H" would be disassembled as "CMPAR AC0, AX1.H",
leading to pain and confusion.
  • Loading branch information
delroth committed Dec 13, 2014
1 parent 9e0a198 commit 0b90941
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gcdsp_generated.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@
["MULXMV",0xa600,0xe600,1,3,[[OpType.REGM18,1,0,11,0x1000],[OpType.REGM19,1,0,10,0x0800],[OpType.ACC,1,0,8,0x0100]],True,False],
["TST",0xb100,0xf700,1,1,[[OpType.ACC,1,0,11,0x0800]],True,False],
["MULC",0xc000,0xe700,1,2,[[OpType.ACCM,1,0,12,0x1000],[OpType.REG1A,1,0,11,0x0800]],True,False],
["CMPAR",0xc100,0xe700,1,2,[[OpType.ACC,1,0,12,0x1000],[OpType.REG1A,1,0,11,0x0800]],True,False],
["CMPAR",0xc100,0xe700,1,2,[[OpType.ACC,1,0,11,0x0800],[OpType.REG1A,1,0,12,0x1000]],True,False],
["MULCMVZ",0xc200,0xe600,1,3,[[OpType.ACCM,1,0,12,0x1000],[OpType.REG1A,1,0,11,0x0800],[OpType.ACC,1,0,8,0x0100]],True,False],
["MULCAC",0xc400,0xe600,1,3,[[OpType.ACCM,1,0,12,0x1000],[OpType.REG1A,1,0,11,0x0800],[OpType.ACC,1,0,8,0x0100]],True,False],
["MULCMV",0xc600,0xe600,1,3,[[OpType.ACCM,1,0,12,0x1000],[OpType.REG1A,1,0,11,0x0800],[OpType.ACC,1,0,8,0x0100]],True,False],
Expand Down

0 comments on commit 0b90941

Please sign in to comment.