DolphinQt: Patches window added #9531
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepalani
force-pushed
the
patch-widgets
branch
from
7cf6ea4 to
1ac3455
Compare
iwubcode
reviewed
Mar 6, 2021
| std::vector<std::string> patches; | ||
| for (const auto& patch : m_patches) | ||
| { | ||
| std::ostringstream oss; |
There was a problem hiding this comment.
I wonder if it makes sense to make a fmt::formatter for MemoryPatch then you just do: fmt::to_string(patch)...
There was a problem hiding this comment.
Another option is to implement std::ostream& operator<< and use fmt's ostream support, if that'd make it easier to be consistent with the parsing code.
iwubcode
reviewed
Mar 6, 2021
| if (!PowerPC::HostIsRAMAddress(address)) | ||
| return; | ||
|
|
||
| const bool is_enabled = patch.is_enabled == Common::Debug::MemoryPatch::State::Enabled; |
There was a problem hiding this comment.
I've seen this a couple times, maybe it makes sense to make a function?
|
One other idea, maybe adding a 'note' field or 'description' would be useful. |
|
Can you rebase this on master? |
|
Sure. However, I'm not satisfied with the current PR state anymore. There are some improvements I'd like to make first, so I'll switch this PR as a draft meanwhile. |
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a widget to handle memory patches like replaced instructions. (based on #7081)
At the moment, it looks like this:
There are few things I need to address before making this PR ready to merge:
ClearPatches()is called on shutdown (MMU: Fix IsRAMAddress not working #9533)Add button to inject a file into a specific memory address(will be done in another PR)Ready to be reviewed & merged (depends on #9533).