Migrate to SFML 3.0.0 #13276
Open
Migrate to SFML 3.0.0 #13276
+207
−9,898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaVandaele
force-pushed
the
sfml-3.0.0
branch
from
6e3e106 to
ad0e093
Compare
JoshuaVandaele
force-pushed
the
sfml-3.0.0
branch
2 times, most recently
from
01d196c to
953ec83
Compare
|
The change in graphical rendering seems to happen to multiple PRs so I think this is unrelated, however I'm not sure why the OSX build fails and I'm unable to test it locally considering I don't own a single Apple device, I'm unsure how to proceed? |
|
OSX looks like it uses an old compiler for SFML, as it complains about (And yes, feel free to ignore fifoci.) |
|
Oh wow I fixed it with my first attempt, amazing! Let me rebase |
JoshuaVandaele
force-pushed
the
sfml-3.0.0
branch
from
c5bf042 to
a447850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFML 3.0.0 released last week, with some breaking changes. I'm taking the occasion to make SFML a submodule, as well as migrating the code to work with >=3.0.0.
So far, I've tested using Netplay on Linux with a copy of Mario Kart Wii and everything seems to works fine, but I'd appreciate more testing, particularly with Gamecube games since I do not own any.