Vulkan DRM/KMS support #13222
Vulkan DRM/KMS support #13222
Conversation
|
First time contributing, not sure if those ci's are normal. Will look later |
|
No, those results are unexpected. |
Oh, is it literally empty, lol.... |
|
Probably has to do with it being on by default, will fix tomorrow |
|
@dolphin-emu-bot rebuild |
|
I think everything should be fixed next run |
|
Gave this PR a try to see if it changes the dGPU flatpak error since KHR fails, but no change. Unrelated. |
Sorry, wish it helped yah |
You can run the Tools/lint.sh script locally to catch the linter. |
I believe it should be good now, was using that lint script incorrectly. |
|
Dolphin ci hates me 😕 |
|
|
|
Thank you @BhaaLseN |
|
@camdenorrb squash the comment removal commit and you should be good to merge assuming other graphics approvals |
|
@dreamsyntax done, not sure how to get graphics approvals |
| PRIVATE | ||
| ${CMAKE_SOURCE_DIR}/Externals/Vulkan-Headers/include | ||
| ${CMAKE_SOURCE_DIR}/Externals/VulkanMemoryAllocator/include | ||
| ${CMAKE_SOURCE_DIR}/Externals/libadrenotools/include | ||
| PRIVATE | ||
| ${CMAKE_SOURCE_DIR}/Externals/Vulkan-Headers/include | ||
| ${CMAKE_SOURCE_DIR}/Externals/VulkanMemoryAllocator/include | ||
| ${CMAKE_SOURCE_DIR}/Externals/libadrenotools/include |
There was a problem hiding this comment.
I don't disagree with this formatting change, but since there are no other changes besides formatting I'm not sure it should be in this PR.
Nitpick though, leave it or not. I have no preference, but a graphics reviewer might.
| @@ -13,6 +13,7 @@ enum class WindowSystemType | |||
| Wayland, | |||
| FBDev, | |||
| Haiku, | |||
| DRM, | |||
There was a problem hiding this comment.
I'm not sure why this is highlighted in blue, its not a C++ keyword. Anyone know?
There was a problem hiding this comment.
Probably just a syntax highlighting glitch
| @@ -36,6 +36,7 @@ static void ResetVulkanLibraryFunctionPointers() | |||
| #define VULKAN_INSTANCE_ENTRY_POINT(name, required) name = nullptr; | |||
| #define VULKAN_DEVICE_ENTRY_POINT(name, required) name = nullptr; | |||
| #include "VideoBackends/Vulkan/VulkanEntryPoints.inl" | |||
|
|
|||
There was a problem hiding this comment.
Same comment as my other, there are no changes to VulkanLoader.cpp other than formatting.
| // TODO: Is this sleep appropriate? | ||
| std::this_thread::sleep_for(std::chrono::milliseconds(1)); |
There was a problem hiding this comment.
I am interested to hear those more experienced with Dolphin who can weigh on for this.
Once finalized I can do a bunch of user testing of this branch.
There was a problem hiding this comment.
This is just copied and pasted from a different platform
|
@mitaclaw any thoughts on this PR? |
|
@camdenorrb am I understanding correctly this makes the below: Obsolete? |
@dreamsyntax those both look wayland specific, so shouldn't make it obsolete |
Utilizes vkCreateDisplayPlaneSurfaceKHR to create a DRM/KMS level surface.
This allows you to avoid dependency on X11, Wayland and other window systems