VideoCommon: optimize asset loading system #12916
Open
+535
−100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the asset loading system to optimize it. A brief overview is given below.
The old system
recursive_mutex
, this seems to have had a chance to cause a crash on some MacOS machinesThe new system
Testing
I have tested on Windows (11) both DIT and texture pack loads.
The 'watcher' library has a couple of minor Windows bugs that I am working with the author to iron out but they shouldn't block this feature.(EDIT: Done) I need testing from other platforms (Android, Mac, Linux) to confirm all functionality operates and to get feedback from users with lower end system.Windows DIT: Working
Windows Performance Experience: Positive, noticeably faster
MacOS DIT: Working
MacOS Performance Experience: --
Linux DIT: --
Linux Performance Experience: --
Android DIT: --
Android Performance Experience: --