Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Update gradle wrapper #12805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TacoTheDank
Copy link
Contributor

Currently they are 9 years old. That is quite ancient. It would be good for them to be kept completely up-to-date. This may improve building times on local machines. This will also fix potential security vulnerabilities the current outdated JAR may have. See here for why updating these is recommended.

For obvious security purposes (a jar file has been modified), the command I ran was ./gradlew wrapper --gradle-version 8.7 --distribution-type bin in Git Bash. You can independently verify the integrity of these files by running this command on your own machine and then using a file comparison tool (like WinMerge for example) to compare the results between this PR and your machine.

The updated JAR's integrity can be verified through this as well: https://gradle.org/release-checksums/

@dreamsyntax
Copy link
Member

dreamsyntax commented Jan 9, 2025

It would be nice to be on 8.10.2 now that Google's AGP 8.8 recommend it.
But seeing as we didn't update AGP; I think just merge this as is until someone wants to do that.

Ended up doing it here, we could close this
#13271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants